Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating icon locations #7110

Merged
merged 3 commits into from
May 24, 2023

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented May 22, 2023

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes N/A

Proposed Changes

Makes it so that icon locations are properly updated.

Reason for Changes

Important for dragging blocks with open bubbles,

Test Coverage

Manually tested with new warning icons (will open PR in a bit).

Documentation

N/A

Additional Information

Dependent on #7101

@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 22, 2023
@BeksOmega BeksOmega mentioned this pull request May 22, 2023
4 tasks
@BeksOmega BeksOmega force-pushed the fix/updating-icon-locations branch from 920b17d to ed7d280 Compare May 22, 2023 20:11
@BeksOmega BeksOmega marked this pull request as ready for review May 22, 2023 20:15
@BeksOmega BeksOmega requested a review from a team as a code owner May 22, 2023 20:15
@BeksOmega BeksOmega requested a review from NeilFraser May 22, 2023 20:15
@BeksOmega BeksOmega mentioned this pull request May 23, 2023
4 tasks
@BeksOmega BeksOmega merged commit 5b2529a into google:develop May 24, 2023
@BeksOmega BeksOmega deleted the fix/updating-icon-locations branch May 14, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants