chore: use prettier instead of clang-format

[maribethb]

The basics

• I branched from develop
• My pull request is against develop
• My code follows the style guide
• I ran npm run format and npm run lint

The details

Resolves

Fixes #6993 (by using prettier instead of clang-format)

Proposed Changes

This PR best reviewed commit-by-commit:

• Adds Prettier tool and config; used eslint-prettier-config to remove conflicting eslint rules
• Removes clang-format tool, config, and references
• Reformats all files in project
  • Removed all clang-format off comments, only added two prettier-disable comments. Prettier treated some lines that had to be ignored by clang a lot better and we don't have to ignore them.
• Updates eslint config to also lint ts files outside of core/
• Fixes newly revealed lint problems in blocks/

Behavior Before Change

Behavior After Change

No actual behavior changes.

Notable format changes:

• Space after function keyword in anonymous functions. This makes it consistent that there is always a space after the function keyword just like every other keyword
• If there are too many parameters to fit on one line, each one gets its own line, with closing bracket also on own line
• Multiple destructured imports are one per line

Reason for Changes

Clang-format doesn't handle TypeScript well. We were having to disable it entirely in the blocks/ directory. Indeed, there is even an issue where we note something that clang-format mangled. Prettier handles this better and is more readable.

Test Coverage

Tests pass. Manual inspection of files. I spot-checked several hundred files for formatting problems.

Pushed a commit with bad format to make sure the github action worked and it did.

Documentation

Additional Information

[rachel-fenichel]

Two questions, but overall lgtm and I'm happy to get rid of our use of that random clang-format github action.

[rachel-fenichel]

Did prettier rewrite this into an arrow function, or did you do that?

[maribethb]

I did this, to resolve lint errors related to redefining this

[rachel-fenichel]

Oh good. I was not stoked about automated rewriting of functions into arrow functions.

[rachel-fenichel]

Prettier changed indentation in a bunch of yaml files. Please confirm that it's still file/the indentation is irrelevant.

[maribethb]

Yup, I ran two of them through a yaml validator/formatter and they pass, and the old contents are reformatted to look like the new contents

[rachel-fenichel]

LGTM once you fix conflicts

[maribethb]

I've fixed conflicts, re-run prettier after rebasing, and removed the requirement of clang-format from the develop branch. After pressing merge I'll require the new action instead.