chore: make clang-format and eslint agree in more places

[maribethb]

The basics

• I branched from develop
• My pull request is against develop
• My code follows the style guide
• I ran npm run format and npm run lint

The details

Resolves

Work on #6993

Proposed Changes

• Updates the GitHub Action clang-format to run on generators and mocha tests as well
• Updates the local clang-format to run on the same, and not blocks (for now, see the issue for more info)
• Updates eslint config to use 80 as the line length, and adds an exception for template literals and import/export statements (which approximates what clang-format does)
• Updates the clang-format rules to set JavaScriptQuotes to Leave. I do not know why I had to set this, because I checked the google style config and it's supposed to be the default option. Despite that, if I did not set it here, it changed multiple instances like const codeStringThatContainsStrings = "import 'foo'" to 'import \'foo\'' which is probably undesirable (though in all of the code in core, we do just escape the single quotes, probably because of this formatting rule). This is also important because otherwise JSON blobs in tests (which are constructed manually, not using json.stringify) would be converted to single quotes and potentially break some tests.
• Runs the formatter (and eslint auto-fixer) on all the code after these rules are applied, so changes to non-configuration files are the result of these tools, with two exceptions:
  • Added a clang-format disable to one test with a bulky multi-line array that clang-format would butcher but isn't typical of our codebase. Apologies, forgot to stick this in its own commit but it's here
  • Added an eslint-disable to one comment that was already being ignored by clang-format. (in its own commit)
• Fixes a missing semicolon that causes compilation errors after formatting
• Updates the CI action to NOT lint the tests/mocha/.mocharc.js file. By default this CI action lints dotfiles but local does not. To resolve this discrepancy, you have two options:
  • Specifically exclude this dotfile
  • Have the local clang-format also run on dotfiles. This is possible by passing an option to the gulp task. But the thing clang-format wants to do to this file makes no sense. My only explanation is that somehow it thinks this file is json... there's an option to not have this space in json but not until clang-format 17, which isn't compatible with the CI action we're using

Behavior Before Change

Inconsistent formatting locally vs CI

Behavior After Change

Consistent formatting locally and on CI, and more formatted files.

Reason for Changes

Test Coverage

Documentation

Additional Information

[maribethb]

Closing in favor of #7014