refactor(blocks): Migrate blocks/logic.js to TypeScript
#7003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 tasks
BeksOmega
reviewed
Apr 21, 2023
Manual resolutions: - Delete core/mutator.ts from this branch (the change to this file made in 86e7a64 has already been made in develop). - In blocks/logic.ts, make core/icons/mutator_icon.js a side-effects only import (as is the case, albeit with goog.require, in develop) - Also change one comment referrint to Mutator to refer to MutatorIcon instead.
|
I believe this is now ready for re-review. |
BeksOmega
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Part of #6828.
Additional Info
Holding off on clang-formatting as it makes some very questionable choices, which I have raised a query about.