Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(blocks): Migrate blocks/logic.js to TypeScript #7003

Merged
merged 7 commits into from
Jun 16, 2023
Merged

refactor(blocks): Migrate blocks/logic.js to TypeScript #7003

merged 7 commits into from
Jun 16, 2023

Commits on Apr 21, 2023

  1. refactor(blocks): Auto-migration of blocks/logic.js to ts

    @cpcallen
    cpcallen committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    e3e5d63 View commit details
    Browse the repository at this point in the history

  2. fix(blocks): Manually migrate & fix types in logic.ts

    @cpcallen
    cpcallen committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    86e7a64 View commit details
    Browse the repository at this point in the history

  3. chore(blocks): Fix import order

    @cpcallen
    cpcallen committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    063b487 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Merge branch 'develop' into fix/6828/blocks/logic 

    Manual resolutions:

- Delete core/mutator.ts from this branch (the change to this file
  made in 86e7a64 has already been made in develop).
- In blocks/logic.ts, make core/icons/mutator_icon.js a side-effects
  only import (as is the case, albeit with goog.require, in develop)
- Also change one comment referrint to Mutator to refer to MutatorIcon
  instead.
    @cpcallen
    cpcallen committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    5713043 View commit details
    Browse the repository at this point in the history

  2. chore(blocks): Fixes for PR google#7003

    @cpcallen
    cpcallen committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    a35e535 View commit details
    Browse the repository at this point in the history

  3. chore(blocks): Lint removal

    @cpcallen
    cpcallen committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    611906e View commit details
    Browse the repository at this point in the history

  4. chore(blocks): Format blocks/logic.ts

    @cpcallen
    cpcallen committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    120c461 View commit details
    Browse the repository at this point in the history