fix: improve collapse / uncollapse performance #6860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
BeksOmega
force-pushed
the
fix/collapse-performance
branch
from
fe6c000
to
b4ea4ce
Compare
BeksOmega
force-pushed
the
fix/collapse-performance
branch
from
b4ea4ce
to
d592467
Compare
This was referenced Mar 2, 2023
NeilFraser
approved these changes
Mar 7, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes N/A
Related to #6786
Proposed Changes
Updates methods related to collapsing to use the
queueRendermethod instead ofrender.Changes
bumpNeighboursto always queue a bump, instead of bumping immediately.Reason for Changes
Performance and performance.
Test Coverage
Only manual testing :/
Documentation
Additional Information
Dependent on #6859