fix: updating connections in the db multiple times #6859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
BeksOmega
force-pushed
the
fix/connection-db-overhead
branch
from
158effd
to
405cd68
Compare
BeksOmega
force-pushed
the
fix/connection-db-overhead
branch
from
405cd68
to
97352c8
Compare
maribethb
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Works on #6786 as a follow up to #6851
Proposed Changes
Separates out updating connection locations into a separate pass, specifically when using the render queue (normal immediate rendering is unaffected).
Reason for Changes
This means that we are no longer recursively moving all of the child blocks every time we tighten a parent block (which was causing us to do a lot of duplicate work adding and removing things from the connection db). It also eliminates a heck-ton of calls to
getRelativeToSurfaceXY, which is a pretty expensive function.This makes rerendering ~ 2.5x faster when you're moving a bunch of connections. E.g. when you're wrapping a new if-block around the spaghetti stress test blocks.
Test Coverage
Just manual testing =(
Documentation
N/A
Additional Information
Dependent on #6851