Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnamed procedures #6723

Closed
wants to merge 11 commits into from

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Work on #6526

Proposed Changes

An issue was discovered when refactoring tests to tick the clock in #6721 that unnamed procedure callers were not properly beinga ssociated with their new definitions. This fixes that.

Reason for Changes

Fixing bugs is happy =)

Test Coverage

Reenabled failing tests.

Documentation

N/A

Additional Information

Dependent on #6722

@BeksOmega BeksOmega requested a review from a team as a code owner December 22, 2022 19:11
@BeksOmega BeksOmega requested a review from cpcallen December 22, 2022 19:11
@BeksOmega BeksOmega marked this pull request as draft December 22, 2022 19:12
@github-actions github-actions bot added the PR: fix Fixes a bug label Dec 22, 2022
@BeksOmega BeksOmega force-pushed the fix/unnamed-procedures branch from 8207320 to 6e61472 Compare December 22, 2022 20:48
@BeksOmega BeksOmega mentioned this pull request Jan 4, 2023
4 tasks
@BeksOmega BeksOmega force-pushed the fix/unnamed-procedures branch from 6e61472 to e4c2de5 Compare January 6, 2023 00:13
@BeksOmega BeksOmega force-pushed the fix/unnamed-procedures branch from e4c2de5 to 9381240 Compare January 6, 2023 22:19
@BeksOmega
Copy link
Collaborator Author

This is no longer broken after change made to #6718 So I'm going to close this and revert the skipping in #6722

@BeksOmega BeksOmega closed this Jan 6, 2023
@BeksOmega BeksOmega deleted the fix/unnamed-procedures branch May 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants