fix: undoing and redoing parameter events #6721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
changed the title
This was referenced Dec 22, 2022
BeksOmega
force-pushed
the
fix/parameter-events
branch
from
17c3cc2
to
ed3063b
Compare
BeksOmega
force-pushed
the
fix/parameter-events
branch
from
ed3063b
to
2facdad
Compare
|
Unskipped the unnamed caller tests because after changes to #6718 these are no longer broken. |
maribethb
approved these changes
Jan 6, 2023
blocks/procedures.js
Outdated
| return null; | ||
| } | ||
| const params = this.getProcedureModel().getParameters(); | ||
| if (!params.length && this.hasStatements_) return; |
There was a problem hiding this comment.
nit: add undefined to the return type for this function
(nit because i'm not sure anything is currently checking/enforcing these types...?)
There was a problem hiding this comment.
Ah whoops, thanks for the catch. This actually needs to return null, not undefined!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6040
Work on #6526
Proposed Changes
Fixes two bugs found with undo and redo and parameters:
Reason for Changes
Fixing bugs is fun!
Test Coverage
Added tests for undoing and redoing:
Also changes a bunch of tests to properly tick the clock instead of calling
composeor doing other things.Documentation
N/A
Additional Information
Had to skip some tests for dealing with unnamed procedures, because once I fixed them to properly tick the clock, I found out they were broken. They are fixed in a follow-up PR.
Dependent on #6718