Add additional logic for auto-scrolling workspace #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alschmiedt
approved these changes
Jun 9, 2021
| @@ -34,7 +39,51 @@ export class ScrollBlockDragger extends Blockly.BlockDragger { | |||
| * @protected | |||
| */ | |||
| this.dragDelta_ = new Blockly.utils.Coordinate(0, 0); | |||
|
|
|||
| // TODO(maribethb): See if we can actually check this | |||
There was a problem hiding this comment.
We have isMovable etc that I want to use to get these dynamically (no need to calculate if we can't even scroll horizontally) but I want to do more thorough testing, so in another PR. But I improved the todo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional logic/conditions for when the workspace should auto-scroll. This version takes into account the mouse/cursor location, as well as the full block dimensions rather than just the corner of the block. The speed changes depending on how far out of bounds you are dragging.
I used the same options that code.org is using in their implementation. It seems a little fast to me, but I'm no expert.
In the next PR, I'll add the ability for a developer to supply any/all of these options, as well as the ability to disable the feature completely (and/or disable the mousewheel handler as well). In addition, everything in this class is overridable so a developer could also subclass the ScrollBlockDragger in order to provide different logic.
Screen.Recording.2021-06-07.at.1.47.17.PM.mov