Bug : Fix date indexing #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingtang10
requested changes
Apr 12, 2021
core/src/main/java/com/google/android/fhir/index/entities/DateIndex.kt
Outdated
Show resolved
Hide resolved
|
thanks for the draft! @epicadk |
epicadk
requested review from
deepankarb,
kevinmost,
pankajkatoch and
yigit
as code owners
jingtang10
requested changes
Apr 12, 2021
core/src/main/java/com/google/android/fhir/db/impl/entities/DateIndexEntity.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/google/android/fhir/index/entities/DateIndex.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/google/android/fhir/index/ResourceIndexer.kt
Outdated
Show resolved
Hide resolved
|
Done @jingtang10 |
jingtang10
approved these changes
Apr 19, 2021
|
Thanks @epicadk for the contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #433
Description
Clear and concise code change description.
Added precision to ts_high in the date index to comply with the standard.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
We could index precision however I don't really see a usecase.
Type
Choose one: Bug fix
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project./gradlew checkand./gradlew connectedCheckto test my changes locally