Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor syncUpload method to utilise new ResultProcessor Interface #2120

Closed
wants to merge 1 commit into from
Closed

Refactor syncUpload method to utilise new ResultProcessor Interface #2120

wants to merge 1 commit into from

Conversation

omarismail94
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2103

Description
Clear and concise code change description.

Encapsulate the processing logic in syncUpload into a new interface called ResultProcessor. The new structure should enable future enhancements and custom processing logic without requiring modifications to the core syncUpload method.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@omarismail94 omarismail94 requested review from santosh-pingle and a team as code owners August 8, 2023 12:21
@omarismail94 omarismail94 requested a review from aditya-07 August 8, 2023 12:21
@omarismail94
Copy link
Contributor Author

Closing in favour of PR #2137

@omarismail94 omarismail94 deleted the derrida branch December 20, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Upload Work Manager - API refactoring
1 participant