Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Work Manager - API refactoring #2103

Closed
anchita-g opened this issue Jul 28, 2023 · 0 comments · Fixed by #2135, #2137, #2156, #2166 or #2121
Closed

Upload Work Manager - API refactoring #2103

anchita-g opened this issue Jul 28, 2023 · 0 comments · Fixed by #2135, #2137, #2156, #2166 or #2121
Assignees

Comments

@anchita-g
Copy link
Collaborator

          Discussed this with @anchita-g. One alternative way of handling this is to make the `UploadWorkManager` a little more stateful, similar to the `DownloadWorkManager`. In that case, there would be an API to feed local changes to the `UploadWorkManager`, there will be an API to pull next upload request to be sent to the FHIR server, and there'll be an API to get the sync status - almost like an iterator with a sync progress.

That would make the job of Uploader a little simpler - the while loop currently in UplaoderImpl would be simplified (because the work is done by the UploadWorkManager. This affords the developers a little more control - but admittedly we're not entirely sure if the additional contronl is urgently needed by the developers.

But that would make the design more alinged with the download workflow which @omarismail94 worked on.

FYI @aditya-07 as well.

Originally posted by @jingtang10 in #2022 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment