-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common library bug fixes and code refactoring #2082
Merged
omarismail94
merged 10 commits into
google:master
from
khyativyasargus:common-library-canonical-form-covert-ucum-bug-fixes
Jul 21, 2023
Merged
Common library bug fixes and code refactoring #2082
omarismail94
merged 10 commits into
google:master
from
khyativyasargus:common-library-canonical-form-covert-ucum-bug-fixes
Jul 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome code refactoring and bug fixes done in common lib
jingtang10
approved these changes
Jul 19, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/validation/MinLengthValidator.kt
Show resolved
Hide resolved
…vert-ucum-bug-fixes' into common-library-canonical-form-covert-ucum-bug-fixes
jingtang10
approved these changes
Jul 20, 2023
@khyativyasargus this test is failing:
can you fix please |
…vert-ucum-bug-fixes' into common-library-canonical-form-covert-ucum-bug-fixes
auto-merge was automatically disabled
July 20, 2023 16:35
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #881
Description
Added support to compare units even if canonical conversion fails & some code refactoring and bug fixes done in common lib
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.