Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common library bug fixes and code refactoring #2082

Conversation

khyativyasargus
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #881

Description
Added support to compare units even if canonical conversion fails & some code refactoring and bug fixes done in common lib

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

…ome code refactoring and bug fixes done in common lib
@omarismail94
Copy link
Contributor

omarismail94 commented Jul 20, 2023

@khyativyasargus this test is failing:

com.google.android.fhir.datacapture.validation.MinValueValidatorTest > should return invalid result when entered value is less than minValue for cqf calculated expression FAILED
    com.google.common.truth.ComparisonFailureWithFacts at MinValueValidatorTest.kt:149

can you fix please

…vert-ucum-bug-fixes' into common-library-canonical-form-covert-ucum-bug-fixes
auto-merge was automatically disabled July 20, 2023 16:35

Head branch was pushed to by a user without write access

@omarismail94 omarismail94 merged commit d62ca13 into google:master Jul 21, 2023
MJ1998 pushed a commit to MJ1998/android-fhir that referenced this pull request Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Quantity type is not supported yet for minValue and MaxValue extension
4 participants