Quantity type is not supported yet for minValue and MaxValue extension #881

santosh-pingle · 2021-10-27T09:41:41Z

Is your feature request related to a problem? Please describe.
It gives error not implemented yet.

Implemented below unit test, but it had thrown quantity type is not implemented yet.

@Test
  @UiThreadTest
  fun displayValidationResult_validValue_shouldAssignErrorNull() {
    viewHolder.bind(
      QuestionnaireItemViewItem(
        Questionnaire.QuestionnaireItemComponent().apply {
          addExtension().apply {
            url = "http://hl7.org/fhir/StructureDefinition/minValue"
            setValue(Quantity(2.2))
          }
          addExtension().apply {
            url = "http://hl7.org/fhir/StructureDefinition/maxValue"
            setValue(Quantity(4.4))
          }
        },
        QuestionnaireResponse.QuestionnaireResponseItemComponent().apply {
          addAnswer(
            QuestionnaireResponse.QuestionnaireResponseItemAnswerComponent().apply {
              value = Quantity(3.3)
            }
          )
        }
      ) {}
    )

    assertThat(viewHolder.itemView.findViewById<TextInputEditText>(R.id.textInputEditText).error).isNull()
  }

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

The text was updated successfully, but these errors were encountered:

epicadk · 2021-10-28T06:38:09Z

Isn't this because minValue is suppose to be applied only to date, dateTime, time, decimal, integer?
As mentioned here.

I think we could improve the error message to say quantity type is not supported by the min/maxvalue extensions.

santosh-pingle · 2021-10-29T16:22:36Z

Can't we jut mark this ticket invalid and also not include test? as you rightly mentioned minValue and maxValue supported types.

epicadk · 2021-10-29T18:36:18Z

Can't we jut mark this ticket invalid and also not include test? as you rightly mentioned minValue and maxValue supported types.

I agree, but do you think the NotImplementedError thrown may be confusing. Maybe we could replace that with an IllegalArgumentException?

jingtang10 · 2021-12-08T18:44:06Z

Isn't this because minValue is suppose to be applied only to date, dateTime, time, decimal, integer? As mentioned here.

I think we could improve the error message to say quantity type is not supported by the min/maxvalue extensions.

yeah i don't undrestand why shouldn't the min/max value validation support quantity - i kinda feel like we should propose a change to the standard. can you do that please @epicadk (if you agree)?

i kinda think we should at least try to compare on a best-effort basis and in this case the unit test shouldn't throw exception.

jingtang10 · 2021-12-09T16:54:53Z

please see http://build.fhir.org/ig/HL7/sdc/behavior.html

epicadk · 2021-12-09T17:01:26Z

please see http://build.fhir.org/ig/HL7/sdc/behavior.html

that's interesting, so we probably want to support minQuantity and maxQuantity extensions. I would be open to working on this.

jingtang10 · 2021-12-09T20:08:12Z

@epicadk you already have a few things on your plate. If you don't mind let's let @juanchazo work on this and for you for focus on the other issues? Thanks

epicadk · 2021-12-09T20:10:07Z

@epicadk you already have a few things on your plate. If you don't mind let's let @juanchazo work on this and for you for focus on the other issues? Thanks

Oh sure

delcroip · 2023-02-22T12:03:38Z

linked to #1849

delcroip · 2023-07-10T08:24:10Z

Dear all,

it works on some quantity but not all

this "works" (the error message show null instead of the boundary, we do have a fork that push the unit from http://hl7.org/fhir/StructureDefinition/questionnaire-unit which is not the fully correct way, here is the PR that should be more correct #2014)

        {
            "extension": [
                {
                    "url": "http://hl7.org/fhir/StructureDefinition/minValue",
                    "valueQuantity": {
                        "value": 0.5,
                        "system": "http://unitsofmeasure.org",
                        "code": "kg"
                    }
                },
                {
                    "url": "http://hl7.org/fhir/StructureDefinition/maxValue",
                    "valueQuantity": {
                        "value": 40.0,
                        "system": "http://unitsofmeasure.org",
                        "code": "kg"
                    }
                },
                {
                    "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-unit",
                    "valueCoding": {
                        "system": "http://unitsofmeasure.org",
                        "code": "kg"
                    }
                },
                {
                    "url": "http://hl7.org/fhir/uv/sdc/StructureDefinition/sdc-questionnaire-enableWhenExpression",
                    "valueExpression": {
                        "language": "text/fhirpath",
                        "expression": "%resource.repeat(item).where(linkId='EmCare.B6.DE07').answer.first().empty()"
                    }
                }
            ],
            "linkId": "EmCare.B6.DE06",
            "text": "Weight (Kg)",
            "type": "quantity",
            "required": true,
            "repeats": false,
}

but this does not (I simplified with only minValue but still failed)

 {
            "extension": [
                {
                    "url": "http://hl7.org/fhir/StructureDefinition/minValue",
                    "valueQuantity": {
                        "value": 0,
                        "system": "http://unitsofmeasure.org",
                        "code": "Cel"
                    }
                },
                {
                    "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-unit",
                    "valueCoding": {
                        "system": "http://unitsofmeasure.org",
                        "code": "Cel"
                    }
                }
            ],
            "linkId": "rest",
            "text": "What is the room temperature",
            "type": "quantity",
            "required": false,
            "repeats": false
        }

here is the error I am getting

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.argusoft.who.emcare.debug, PID: 17054
    com.google.android.fhir.ConverterException: Missing numerical value in the canonical UCUM value
        at com.google.android.fhir.UnitConverter.getCanonicalForm(UnitConverter.kt:63)
        at com.google.android.fhir.MoreTypesKt.compareTo(MoreTypes.kt:68)
        at com.google.android.fhir.datacapture.validation.MinValueValidator$1.invoke(MinValueValidator.kt:36)
        at com.google.android.fhir.datacapture.validation.MinValueValidator$1.invoke(MinValueValidator.kt:33)
        at com.google.android.fhir.datacapture.validation.AnswerExtensionConstraintValidator.validate(AnswerExtensionConstraintValidator.kt:48)
        at com.google.android.fhir.datacapture.validation.QuestionnaireResponseItemValidator.validate(QuestionnaireResponseItemValidator.kt:57)
        at com.google.android.fhir.datacapture.QuestionnaireViewModel.getQuestionnaireAdapterItems(QuestionnaireViewModel.kt:711)
        at com.google.android.fhir.datacapture.QuestionnaireViewModel.getQuestionnaireAdapterItems(QuestionnaireViewModel.kt:679)
        at com.google.android.fhir.datacapture.QuestionnaireViewModel.getQuestionnaireState(QuestionnaireViewModel.kt:627)
        at com.google.android.fhir.datacapture.QuestionnaireViewModel.access$getQuestionnaireState(QuestionnaireViewModel.kt:85)
        at com.google.android.fhir.datacapture.QuestionnaireViewModel$questionnaireStateFlow$1.invokeSuspend(QuestionnaireViewModel.kt:446)
        at com.google.android.fhir.datacapture.QuestionnaireViewModel$questionnaireStateFlow$1.invoke(Unknown Source:9)
        at com.google.android.fhir.datacapture.QuestionnaireViewModel$questionnaireStateFlow$1.invoke(Unknown Source:20)
        at kotlinx.coroutines.flow.FlowKt__ZipKt$combine$$inlined$combineUnsafe$FlowKt__ZipKt$1$2.invokeSuspend(Zip.kt:333)
        at kotlinx.coroutines.flow.FlowKt__ZipKt$combine$$inlined$combineUnsafe$FlowKt__ZipKt$1$2.invoke(Unknown Source:13)
        at kotlinx.coroutines.flow.FlowKt__ZipKt$combine$$inlined$combineUnsafe$FlowKt__ZipKt$1$2.invoke(Unknown Source:6)
        at kotlinx.coroutines.flow.internal.CombineKt$combineInternal$2.invokeSuspend(Combine.kt:79)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
        at kotlinx.coroutines.EventLoop.processUnconfinedEvent(EventLoop.common.kt:69)
        at kotlinx.coroutines.DispatchedTaskKt.resumeUnconfined(DispatchedTask.kt:245)
        at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:161)
        at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:397)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl(CancellableContinuationImpl.kt:431)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl$default(CancellableContinuationImpl.kt:420)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeWith(CancellableContinuationImpl.kt:328)
        at kotlinx.coroutines.flow.StateFlowSlot.makePending(StateFlow.kt:286)
        at kotlinx.coroutines.flow.StateFlowImpl.updateState(StateFlow.kt:351)
        at kotlinx.coroutines.flow.StateFlowImpl.compareAndSet(StateFlow.kt:321)
        at com.google.android.fhir.datacapture.QuestionnaireViewModel$answersChangedCallback$1.invoke(QuestionnaireViewModel.kt:937)
        at com.google.android.fhir.datacapture.QuestionnaireViewModel$answersChangedCallback$1.invoke(QuestionnaireViewModel.kt:313)
        at com.google.android.fhir.datacapture.views.QuestionnaireViewItem.setAnswer(QuestionnaireViewItem.kt:142)
        at com.google.android.fhir.datacapture.views.factories.EditTextQuantityViewHolderFactory$getQuestionnaireItemViewHolderDelegate$1.handleInput(EditTextQuantityViewHolderFactory.kt:40)
        at com.google.android.fhir.datacapture.views.factories.QuestionnaireItemEditTextViewHolderDelegate$bind$$inlined$doAfterTextChanged$1.afterTextChanged(TextView.kt:98)
        at android.widget.TextView.sendAfterTextChanged(TextView.java:11911)
        at android.widget.TextView$ChangeWatcher.afterTextChanged(TextView.java:15283)
E/AndroidRuntime:     at android.text.SpannableStringBuilder.sendAfterTextChanged(SpannableStringBuilder.java:1291)
        at android.text.SpannableStringBuilder.replace(SpannableStringBuilder.java:591)
        at androidx.emoji2.text.SpannableBuilder.replace(SpannableBuilder.java:314)
        at android.text.SpannableStringBuilder.replace(SpannableStringBuilder.java:521)
        at androidx.emoji2.text.SpannableBuilder.replace(SpannableBuilder.java:304)
        at androidx.emoji2.text.SpannableBuilder.replace(SpannableBuilder.java:48)
        at android.text.method.QwertyKeyListener.onKeyDown(QwertyKeyListener.java:228)
        at android.text.method.TextKeyListener.onKeyDown(TextKeyListener.java:141)
        at androidx.emoji2.viewsintegration.EmojiKeyListener.onKeyDown(EmojiKeyListener.java:58)
        at android.widget.TextView.doKeyDown(TextView.java:9503)
        at android.widget.TextView.onKeyDown(TextView.java:9275)
        at android.view.KeyEvent.dispatch(KeyEvent.java:3508)
        at android.view.View.dispatchKeyEvent(View.java:15395)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1978)
        at com.android.internal.policy.DecorView.superDispatchKeyEvent(DecorView.java:1105)
        at com.android.internal.policy.PhoneWindow.superDispatchKeyEvent(PhoneWindow.java:1961)
        at android.app.Activity.dispatchKeyEvent(Activity.java:4342)
        at androidx.core.app.ComponentActivity.superDispatchKeyEvent(ComponentActivity.java:122)
        at androidx.core.view.KeyEventDispatcher.dispatchKeyEvent(KeyEventDispatcher.java:84)
        at androidx.core.app.ComponentActivity.dispatchKeyEvent(ComponentActivity.java:140)
        at androidx.appcompat.app.AppCompatActivity.dispatchKeyEvent(AppCompatActivity.java:599)
        at androidx.appcompat.view.WindowCallbackWrapper.dispatchKeyEvent(WindowCallbackWrapper.java:59)
        at androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.dispatchKeyEvent(AppCompatDelegateImpl.java:3090)
        at com.android.internal.policy.DecorView.dispatchKeyEvent(DecorView.java:929)
        at android.view.ViewRootImpl$ViewPostImeInputStage.processKeyEvent(ViewRootImpl.java:8056)
        at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:7864)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:7213)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:7270)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:7236)
        at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:7434)
        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:7244)
        at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:7491)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:7217)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:7270)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:7236)
        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:7244)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:7217)
        at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:10788)
E/AndroidRuntime:     at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:10676)
        at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:10632)
        at android.view.ViewRootImpl$ViewRootHandler.handleMessageImpl(ViewRootImpl.java:6822)
        at android.view.ViewRootImpl$ViewRootHandler.handleMessage(ViewRootImpl.java:6697)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loopOnce(Looper.java:226)
        at android.os.Looper.loop(Looper.java:313)
        at android.app.ActivityThread.main(ActivityThread.java:8757)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)
    	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@342d031, Dispatchers.Main.immediate]
    Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.fhir.ucum.Decimal.asDecimal()' on a null object reference
        at com.google.android.fhir.UnitConverter.getCanonicalForm(UnitConverter.kt:57)
        	... 99 more
I/Process: Sending signal. PID: 17054 SIG: 9
Disconnected from the target VM, address: 'localhost:36527', transport: 'socket'

jingtang10 · 2023-07-17T13:57:18Z

Until FHIR/Ucum-java#26 is resolved, I think we can put in a workaround here:

android-fhir/common/src/main/java/com/google/android/fhir/MoreTypes.kt

Line 67 in 9cc2932

this.fhirType().equals("Quantity") -> {

to at least attempt to compare two quantities if they cannot be canonicalized but have the same unit.

@khyativyasargus @delcroip please feel free to send a PR - this should be a quick fix.

santosh-pingle added the type:enhancement New feature or request label Oct 27, 2021

epicadk mentioned this issue Oct 28, 2021

After selecting Temperature unit as Fahrenheit, it is showing minimum and maximum range of Celsius #876

Open

Tarun-Bhardwaj added P3 Low priority issue effort:small Small effort - 2 days labels Nov 10, 2021

jingtang10 assigned juanchazo Dec 8, 2021

Tarun-Bhardwaj added the Data capture label Mar 31, 2022

juanchazo removed their assignment Jun 15, 2022

Tarun-Bhardwaj added this to Android FHIR SDK Sep 12, 2022

Tarun-Bhardwaj moved this to Backlog in Android FHIR SDK Sep 12, 2022

Tarun-Bhardwaj moved this from Backlog to Icebox in Android FHIR SDK Sep 16, 2022

Tarun-Bhardwaj removed the Data capture label Sep 21, 2022

khyativyasargus mentioned this issue Jul 14, 2023

Cannot convert Celcius to canonical Form FHIR/Ucum-java#26

Closed

khyativyasargus mentioned this issue Jul 19, 2023

Common library bug fixes and code refactoring #2082

Merged

7 tasks

omarismail94 closed this as completed in #2082 Jul 21, 2023

github-project-automation bot moved this from Icebox to Complete in Android FHIR SDK Jul 21, 2023

This was referenced Jul 21, 2023

Common lib version update for engine and datacapture with canonical conversion fixes #2089

Closed

Common lib version update for engine and datacapture with canonical conversion fixes #2090

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quantity type is not supported yet for minValue and MaxValue extension #881

Quantity type is not supported yet for minValue and MaxValue extension #881

santosh-pingle commented Oct 27, 2021

epicadk commented Oct 28, 2021 •

edited

Loading

santosh-pingle commented Oct 29, 2021 •

edited

Loading

epicadk commented Oct 29, 2021 •

edited

Loading

jingtang10 commented Dec 8, 2021

jingtang10 commented Dec 9, 2021

epicadk commented Dec 9, 2021

jingtang10 commented Dec 9, 2021

epicadk commented Dec 9, 2021

delcroip commented Feb 22, 2023

delcroip commented Jul 10, 2023

jingtang10 commented Jul 17, 2023

Quantity type is not supported yet for minValue and MaxValue extension #881

Quantity type is not supported yet for minValue and MaxValue extension #881

Comments

santosh-pingle commented Oct 27, 2021

epicadk commented Oct 28, 2021 • edited Loading

santosh-pingle commented Oct 29, 2021 • edited Loading

epicadk commented Oct 29, 2021 • edited Loading

jingtang10 commented Dec 8, 2021

jingtang10 commented Dec 9, 2021

epicadk commented Dec 9, 2021

jingtang10 commented Dec 9, 2021

epicadk commented Dec 9, 2021

delcroip commented Feb 22, 2023

delcroip commented Jul 10, 2023

jingtang10 commented Jul 17, 2023

epicadk commented Oct 28, 2021 •

edited

Loading

santosh-pingle commented Oct 29, 2021 •

edited

Loading

epicadk commented Oct 29, 2021 •

edited

Loading