183624452 swarming adb path #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benchmark command has been refactored in the meantime, such that the way the script uses it is invalid now. We don't use that script in any swarming test.
Make sure all commands used in swarming test scripts use the same ADB command. This can help avoid flakes due to AGI detecting a different ADB than the one that comes by default on swarming bots path. Bug: b/183624452 Test: manual, on all swarming scripts
|
There are two commits, the first one gets rid of an irrelevant test script, the second contains meaningful change. You should first look at the change in botutil.py that defines the BotUtil class and moves various methods under it, and then these methods are used in other scripts. |
johnplate
approved these changes
Apr 1, 2021
hevrard
added a commit
to hevrard/agi
that referenced
this pull request
Apr 8, 2021
The recent refactoring of Swarming scripts to enforce the use of the same ADB everywhere (google#754) overlooked the gpu profiling validation script, this change fixes it. Bug: b/184810080 Test: manual on a local device
hevrard
added a commit
that referenced
this pull request
Apr 9, 2021
The recent refactoring of Swarming scripts to enforce the use of the same ADB everywhere (#754) overlooked the gpu profiling validation script, this change fixes it. Bug: b/184810080 Test: manual on a local device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.