Adding SpotLight to Lighting kit #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the spot_blend and spot_size parameters into the lights.py file. Spot Blend is the roughness of the beam Spot Size is the radius in deg 0 - 180 Blender.py was changed to add the needed parameters inside the blender handler. I think I added the correct identifiers and what not. I just copied the standard implementation as it was written. The SpotLight was added in with the other forms of Lights ---------- Still need to look at the colors of the lights. Maybe refer to the issue in the main github of Kubric regarding the Color Class and its implementation.
Qwlouse
requested changes
Apr 21, 2022
kubric/renderer/blender.py
Outdated
| @@ -474,6 +474,22 @@ def _add_asset(self, obj: core.DirectionalLight): # pylint: disable=function-re | |||
| obj.observe(KeyframeSetter(sun, "energy"), "intensity", type="keyframe") | |||
| return sun_obj | |||
|
|
|||
| def _add_asset(self, obj: core.SpotLight): # pylint: disable=function-redefined | |||
| SpotLight = bpy.data.lights.new(obj.uid, "SPOT") | |||
There was a problem hiding this comment.
nit: lowercase variable names please (snake case)
Awesome notes from Qwlouse! can be found at PR google-research#219
As per google-research#225 fix implemented
updateeeee
|
#225 has been addressed in the PR as it is a one liner
|
Co-authored-by: Klaus Greff <[email protected]>
Bug Fix noted by Qwlouse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the spot_blend and spot_size parameters into the lights.py file.
Spot Blend is the roughness of the beam
Spot Size is the radius in deg 0 - 180 # This might be incorrect?
Blender.py was changed to add the needed parameters inside the blender handler. I think I added the correct identifiers and what not. I just copied the standard implementation as it was written.
The SpotLight was added in with the other forms of Lights
Personal Note:
Still need to look at the colors of the lights. Maybe refer to the issue in the main github of Kubric regarding the Color Class and its implementation and look at reworking for a more wide-spread color use. Need to look into the color implementation.