Use lowercase SchemaType enum values #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you do 2 things: |
This fixes the serialized values of the `SchemaType` enum to follow [the referenced doc](https://swagger.io/docs/specification/data-models/data-types/) and [the json-schema spec](https://json-schema.org/draft/2020-12/json-schema-core#section-4.2.1) on which the reference is based. This change makes the JS gemini SDK compatible with the myriad tools like [AJV](https://ajv.js.org/guide/typescript.html) that allow the definition of validators, types, etc using standard json-schema. In practice the lowercased values appear to work perfectly, but show TypeScript errors.
|
Hi @hsubox76 - thanks for reiterating what y'all already had in the contributing docs, and sorry for not reading those first! 🤦🏼 I've updated and rebased this PR accordingly. |
|
Just wanted to kindly nudge this, at least to let the unit tests run. Thanks! |
|
I'm waiting for this! |
hsubox76
approved these changes
Sep 11, 2024
|
Is this PR solving #153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the serialized values of the
SchemaTypeenum to follow the swagger doc referenced in comments, and the json-schema spec upon which the swagger spec is based.This change makes this package compatible with the myriad other tools (like AJV) that allow the definition of validators, types, etc using standard json-schema.
I've tested sending lowercased values to gemini, and this appears to work perfectly, despite the TypeScript errors that this PR resolves.