Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lowercase SchemaType enum values #430

Open
navarrodiego opened this issue Sep 25, 2024 · 0 comments
Open

Use lowercase SchemaType enum values #430

navarrodiego opened this issue Sep 25, 2024 · 0 comments
Labels
api: aiplatform Issues related to the googleapis/nodejs-vertexai API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@navarrodiego
Copy link

Hey there!

I recently migrated from the @generative-ai-js SDK to the Vertex SDK. In the previous SDK, we had already discussed the benefits of using lowercase SchemaType enum values to align with the OpenAPI standard.

You can refer to this issue and this pull request for more details.

Additionally, I believe both SDKs should be better coordinated. It’s inconsistent for Google SDKs to have different enum styles.
@navarrodiego navarrodiego added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 25, 2024
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the googleapis/nodejs-vertexai API. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: aiplatform Issues related to the googleapis/nodejs-vertexai API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@navarrodiego