New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #8. Use Py3.9 features and type hints #9

Closed

RyanMullins wants to merge 2 commits into main from 8-py39-compatibility

Member

RyanMullins commented Nov 11, 2024 •

edited

Loading

Makes the code compatible with Python 3.9.

Converts | None type hints back to Optional (see PEP 604)
Converts X | Y type hints to Union (see PEP 604)
Removes use of match..case (see PEP 634, 635, 636)
Uses the concrete import from synthid_text instead of the relative import from .
Renames a helper function in the logits processor test to avoid it being picked up as a test case by PyTest


          Fixes #8. Use Py3.9 features and type hints

37a1981

RyanMullins linked an issue

that may be closed by this pull request

Python version #8

Closed

RyanMullins requested a review from sumedhghaisas2

November 11, 2024 15:23


          Use concrete imports. Rename test helper func to avoid pickup by pytest.

54038c7

Member Author

RyanMullins commented Nov 11, 2024

Fixing this in #11 so that we get a CI run in with every PR, too.

RyanMullins closed this

RyanMullins deleted the 8-py39-compatibility branch

November 12, 2024 15:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet