Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.9 compability fixes with tests on GitHub Actions #11

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

RyanMullins
Copy link
Member

@RyanMullins RyanMullins commented Nov 11, 2024

Fixes #8
Fixes #10

Makes the code compatible with Python 3.9.

  • Converts | None type hints back to Optional (see PEP 604)
  • Converts X | Y type hints to Union (see PEP 604)
  • Removes use of match..case (see PEP 634, 635, 636)
  • Removes kw_only= from dataclasses.dataclass() annotation.
  • Uses the concrete import from synthid_text instead of the relative import from .
  • Renames a helper function in the logits processor test to avoid it being picked up as a test case by PyTest

@RyanMullins RyanMullins linked an issue Nov 11, 2024 that may be closed by this pull request
@RyanMullins RyanMullins force-pushed the 10-add-github-action-to-execute-pytest-for-prs branch from ee371a8 to 343f7e3 Compare November 11, 2024 15:53
@RyanMullins RyanMullins force-pushed the 10-add-github-action-to-execute-pytest-for-prs branch from 343f7e3 to dd021e8 Compare November 11, 2024 16:03
@RyanMullins RyanMullins changed the title Fixes #10. Runs PyTest for PRs with GitHub Actions Python 3.9 compability fixes with tests on GitHub Actions Nov 11, 2024
@RyanMullins RyanMullins merged commit f6d3e54 into main Nov 12, 2024
4 checks passed
@RyanMullins RyanMullins deleted the 10-add-github-action-to-execute-pytest-for-prs branch November 12, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub Action to execute PyTest for PRs Python version
2 participants