Event API #902
Merged
Event API #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-group api's based on alpha.4 event api update
Mwu/pay event new params
…harder to deserialzie
nieznanysprawiciel
previously approved these changes
Jan 8, 2021
not true ;) |
tworec
reviewed
Jan 11, 2021
tworec
previously requested changes
Jan 11, 2021
tworec
force-pushed
the
event-api/master
branch
from
ebefd81 to
b88ce0b
Compare
tworec
force-pushed
the
event-api/master
branch
from
6c8c8a9 to
3f76367
Compare
tworec
reviewed
Jan 12, 2021
tworec
reviewed
Jan 12, 2021
Wiezzel
previously approved these changes
Jan 12, 2021
tworec
reviewed
Jan 12, 2021
tworec
reviewed
Jan 12, 2021
- event dao: create timestamp within the transaction fn - fix comments in common.rs
tworec
reviewed
Jan 12, 2021
tworec
reviewed
Jan 12, 2021
| self.notify_agreement(&agreement).await; | ||
|
|
||
| inc_terminate_metrics(&reason, agreement.id.owner()); | ||
| log::info!( | ||
| "Agent {} terminated Agreement [{}]. Reason: {}", | ||
| "{:?} {} terminated Agreement [{}]. Reason: {}", | ||
| agreement.id.owner(), |
There was a problem hiding this comment.
minor: we are not sure here that the owner is terminating
tworec
reviewed
Jan 12, 2021
tworec
reviewed
Jan 12, 2021
tworec
approved these changes
Jan 12, 2021
This was referenced Jan 13, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.