Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revive: convert hard coded excludes into default exclude patterns #1938

Merged
merged 1 commit into from
May 1, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 26, 2021

Fix #1937

The default behavior is still the same, but the PR allows users to use exported and package-comments rules.

@ldez ldez added the linter: update version Update version of linter label Apr 26, 2021
@ldez ldez changed the title revive: convert hard coded into default exclude patterns revive: convert hard coded excludes into default exclude patterns Apr 26, 2021
@ldez ldez added enhancement New feature or improvement and removed linter: update version Update version of linter labels Apr 28, 2021
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM but maybe we should follow up on #456, I se no reason excluding this by default, seems like old legacy because it was excluded for golint way back.

@ldez
Copy link
Member Author

ldez commented May 1, 2021

As revive has been introduced in v1.37, I think we need to keep the excludes for backward compatibility.

@ldez ldez merged commit 34ffdc2 into golangci:master May 1, 2021
@ldez ldez deleted the feat/revive-exclude branch May 1, 2021 16:40
@bombsimon
Copy link
Member

As revive has been introduced in v1.37, I think we need to keep the excludes for backward compatibility.

Yeah I get the idea but a bunch of linters has been updated with breaking changes (new lints etc) without us bumping major version. I have a hart time seeing us ever going to 2.0. But I guess you'll just have to not use --enable-defaults if you want these kind of warnings even though they're (as the issue states) the recommended way in Effective Go.

@ldez ldez added this to the v1.40 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revive: exported rule does not work
2 participants