-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revive: exported rule does not work #1937
Comments
Hello, In fact, it's expected: golangci-lint/pkg/golinters/revive.go Lines 160 to 163 in 54bfbb9
I have an idea to implement that differently. |
Any update on this? It's still skipping |
There is no news on a closed issue. The issue is not related to what you are looking for. By default, golangci-lint excludes this kind of rule. You have to adjust exclusions in the For example, you can do that: issues:
#...
exclude-use-default: false https://golangci-lint.run/usage/configuration/#issues-configuration |
Some rules will be plainly ignored due to the exclusion list. See https://golangci-lint.run/usage/configuration/#issues-configuration and https://golangci-lint.run/usage/false-positives/#exc0012 and golangci/golangci-lint#1937 (comment) Signed-off-by: Daniel Maslowski <[email protected]>
Some rules will be plainly ignored due to the exclusion list. See https://golangci-lint.run/usage/configuration/#issues-configuration and https://golangci-lint.run/usage/false-positives/#exc0012 and golangci/golangci-lint#1937 (comment) Signed-off-by: Daniel Maslowski <[email protected]>
Some rules will be plainly ignored due to the exclusion list. See https://golangci-lint.run/usage/configuration/#issues-configuration and https://golangci-lint.run/usage/false-positives/#exc0012 and golangci/golangci-lint#1937 (comment) Signed-off-by: Daniel Maslowski <[email protected]>
Description of the problem
The
exported
rule from revive is completely ignored. However, if I runrevive
directly, it is properly applied.https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#exported
Also, if I use
golint
in my .golangci.yml instead then these lines are properly flagged.Version of golangci-lint
Config file
Go environment
Verbose output of running
Code example or link to a public repository
The text was updated successfully, but these errors were encountered: