Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: panic: machorelocsect: size mismatch [1.22 backport] #67527

Closed
gopherbot opened this issue May 20, 2024 · 3 comments
Closed

cmd/link: panic: machorelocsect: size mismatch [1.22 backport] #67527

gopherbot opened this issue May 20, 2024 · 3 comments
Labels
arch-arm64 CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. OS-Darwin
Milestone
Go1.22.4

Comments

@gopherbot
Copy link
Contributor

@cherrymui requested issue #66993 to be considered for backport to the next 1.22 minor release.

@gopherbot please backport this to Go 1.22. This causes build failures on darwin/arm64.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 20, 2024
@gopherbot gopherbot mentioned this issue May 20, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 20, 2024
@gopherbot gopherbot added this to the Go1.22.4 milestone May 20, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/586081 mentions this issue: [release-branch.go1.22] cmd/link: add runtime.text.N symbols to macho symbol table in dynlink mode

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label May 22, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 22, 2024
@cagedmantis
Copy link
Contributor

Approved as this is a bug with no workaround.

gopherbot pushed a commit that referenced this issue May 24, 2024
@cherrymui @cagedmantis
[release-branch.go1.22] cmd/link: add runtime.text.N symbols to macho…
cb55d1a 
… symbol table in dynlink mode

In dynamic linking mode (e.g. when using plugins) on darwin, the
marker symbols runtime.text and runtime.etext are added to Textp
in an early stage, so when adding symbols to the symbol table we
don't need to explicitly add them. However, when splitting text
sections, the runtime.text.N marker symbols for the addtional
sections are not added to Textp. So we do need to add them
explicitly to the symbol table.

Updates #66993.
Fixes #67527.

Change-Id: Ic718d03cd71fc0bfb931cff82640b1f4c53b89be
Reviewed-on: https://go-review.googlesource.com/c/go/+/586555
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Than McIntosh <[email protected]>
(cherry picked from commit 9a9dd72)
Reviewed-on: https://go-review.googlesource.com/c/go/+/586081
@gopherbot
Copy link
Contributor Author

Closed by merging cb55d1a to release-branch.go1.22.

@knqyf263 knqyf263 mentioned this issue Jun 21, 2024
Merged
6 tasks
@gabyhelp gabyhelp mentioned this issue Jun 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-arm64 CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. OS-Darwin
Projects
None yet
Milestone
Go1.22.4
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot