Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: Client doesn't send body until ExpectContinueTimeout expires [1.17 backport] #49905

Closed
gopherbot opened this issue Dec 1, 2021 · 3 comments
Closed

x/net/http2: Client doesn't send body until ExpectContinueTimeout expires [1.17 backport] #49905

gopherbot opened this issue Dec 1, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.4

Comments

@gopherbot
Copy link
Contributor

@neild requested issue #49677 to be considered for backport to the next 1.17 minor release.

@gopherbot Please open backport issues for 1.16 and 1.17. This is a regression.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 1, 2021
@gopherbot gopherbot mentioned this issue Dec 1, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.4 milestone Dec 1, 2021
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Dec 1, 2021
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/368475 mentions this issue: [internal-branch.go1.17-vendor] net/http2: Fix handling of expect continue

gopherbot pushed a commit to golang/net that referenced this issue Dec 1, 2021
@mhr3 @mknyszek
[internal-branch.go1.17-vendor] net/http2: Fix handling of expect con…
85e122b 
…tinue

Recent refactoring in the http2 package broke handling of ExpectContinueTimeout, where the client was always waiting for the timeout to pass before sending the body.

For golang/go#49677
Fixes golang/go#49905

Change-Id: I565299e48313bb905b2655bd52084ea49ab742f3
GitHub-Last-Rev: 587b484
GitHub-Pull-Request: #118
Reviewed-on: https://go-review.googlesource.com/c/net/+/363914
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
Trust: Damien Neil <[email protected]>
Run-TryBot: Damien Neil <[email protected]>
(cherry picked from commit 0a0e4e1)
Reviewed-on: https://go-review.googlesource.com/c/net/+/368475
Reviewed-by: Michael Knyszek <[email protected]>
Run-TryBot: Michael Knyszek <[email protected]>
TryBot-Result: Go Bot <[email protected]>
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/368574 mentions this issue: [release-branch.go1.17] net/http: update bundled golang.org/x/net/http2

@mknyszek mknyszek closed this as completed Dec 2, 2021
gopherbot pushed a commit that referenced this issue Dec 2, 2021
@mknyszek
[release-branch.go1.17] net/http: update bundled golang.org/x/net/http2
0177913 
Pull in approved backports to golang.org/x/net/http2:

    85e122b net/http2: Fix handling of expect continue
    1dc0aec http2: don't count aborted streams as active in tests
    e973a42 ipv6: OpenBSD does not appear to support multicast loopback
    9592dd5 http2: avoid busy loop when ResponseHeaderTimeout is set
    94fb2bc http2: avoid spurious RoundTrip error when server closes and resets stream
    e108c19 http2: close conns after use when req.Close is set

By doing:

    $ go get -d golang.org/x/[email protected]
    go: upgraded golang.org/x/net v0.0.0-20211101194204-95aca89e93de => v0.0.0-20211201233630-85e122b1a9b3
    $ go mod tidy
    $ go mod vendor
    $ go generate -run=bundle std

Fixes #49561.
Fixes #49624.
Fixes #49662.
Fixes #49905.
Fixes #49909.
Fixes #49911.

Change-Id: Ia8f432bd3ea77d24e63d46c8ed2ac8d275406b52
Reviewed-on: https://go-review.googlesource.com/c/go/+/368574
Trust: Michael Knyszek <[email protected]>
Run-TryBot: Michael Knyszek <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging 0177913 to release-branch.go1.17.

@knz knz mentioned this issue Jan 10, 2022
Closed
fedosgad pushed a commit to fedosgad/oohttp that referenced this issue Jun 22, 2022
@mhr3 @mknyszek
[internal-branch.go1.17-vendor] net/http2: Fix handling of expect con…
322f395 
…tinue

Recent refactoring in the http2 package broke handling of ExpectContinueTimeout, where the client was always waiting for the timeout to pass before sending the body.

For golang/go#49677
Fixes golang/go#49905

Change-Id: I565299e48313bb905b2655bd52084ea49ab742f3
GitHub-Last-Rev: 587b48407932d44b26399b6c0b4ac228e6889ac8
GitHub-Pull-Request: golang/net#118
Reviewed-on: https://go-review.googlesource.com/c/net/+/363914
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
Trust: Damien Neil <[email protected]>
Run-TryBot: Damien Neil <[email protected]>
(cherry picked from commit 0a0e4e1bb54c236434124a1fa7b0a400de92f2cc)
Reviewed-on: https://go-review.googlesource.com/c/net/+/368475
Reviewed-by: Michael Knyszek <[email protected]>
Run-TryBot: Michael Knyszek <[email protected]>
TryBot-Result: Go Bot <[email protected]>
@golang golang locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.4
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot