builder: upgrade to go 1.17.6 #74617
Assignees
Labels
A-build-system
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-dev-inf
Comments
knz
added
C-bug
|
cc @jlinder for triage |
This was referenced Jan 10, 2022
craig bot
pushed a commit
that referenced
this issue
Jan 18, 2022
74655: *: upgrade to go 1.17.6 r=rail a=rickystewart * [ ] Adjust the Pebble tests to run in new version. * [x] Adjust version in Docker image ([source](./builder/Dockerfile)). * [x] Adjust version in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh)) * [x] Rebuild and push the Docker image (following [Basic Process](#basic-process)) * [x] Download ALL the archives (`.tar.gz`, `.zip`) for the new Go version from https://golang.org/dl/ and mirror them in the `public-bazel-artifacts` bucket in the `Bazel artifacts` project in GCP (sub-directory `go`, next to the other Go SDK's). * [x] Bump the version in `WORKSPACE` under `go_download_sdk`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). * [x] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)). * [x] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release. * [ ] Bump the go version in `go.mod`. You may also need to rerun `make vendor_rebuild` if vendoring has changed. * [x] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)). * [x] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`). * [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects. * [ ] Ask the Developer Infrastructure team to deploy new TeamCity agent images according to [packer/README.md](./packer/README.md) Closes #74617. Closes #74386. Release note (build change): Upgrade to Go 1.17.6 74894: label-merged-pr: use common base commit for finding commits r=rail a=jlinder Previously, the `from` and `to` refs were used directly in the `git log` command to find the list of refs to evaluate. This command also uses the `--ancestry-path` parameter which returns a set of commits only when then `from` ref is an ancestor of the `to` ref. It is common that the `from` ref supplied to the program is not an ancestor of the `to` ref with the expectation that the common base ref of the two refs is used as the `from` ref when determining the the set of commits to evaluate. Now, the common base commit of `from` and `to` is determined and then used as the `from` argument when finding the refs to evaluate. Release note: None 74913: spanconfigsqlwatcher: add a `system.protected_ts_records` decoder r=irfansharif a=adityamaru This change adds a decoder to decode rows from the `system.protected_ts_records` table. This will be used by the rangefeed we setup in the SQLWatcher, to decode rangefeed updates and subsequently feed them into the SQLTranslator. The `target` column of the system table is the only column of interest since it will determine whether we ask the translator to generate `SystemSpanConfig`s or regular `SpanConfigs`. More information about this will be added in follow up PRs that use this decoder. This change also instructs gogoproto to generate an equality method for `roachpb.TenantID`, to allow for equality checks in the decoder test. Informs: #73727 Release note: None 75092: bazci: move test XML logic into `build/util` r=rail a=rickystewart We'll consume it from both `bazci` and `dev` so it should be in a common place. Release note: None Co-authored-by: Ricky Stewart <[email protected]> Co-authored-by: James H. Linder <[email protected]> Co-authored-by: Aditya Maru <[email protected]>
gtr
pushed a commit
to gtr/cockroach
that referenced
this issue
Jan 24, 2022
* [ ] Adjust the Pebble tests to run in new version. * [x] Adjust version in Docker image ([source](./builder/Dockerfile)). * [x] Adjust version in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh)) * [x] Rebuild and push the Docker image (following [Basic Process](#basic-process)) * [x] Download ALL the archives (`.tar.gz`, `.zip`) for the new Go version from https://golang.org/dl/ and mirror them in the `public-bazel-artifacts` bucket in the `Bazel artifacts` project in GCP (sub-directory `go`, next to the other Go SDK's). * [x] Bump the version in `WORKSPACE` under `go_download_sdk`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). * [x] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)). * [x] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release. * [ ] Bump the go version in `go.mod`. You may also need to rerun `make vendor_rebuild` if vendoring has changed. * [x] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)). * [x] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`). * [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects. * [ ] Ask the Developer Infrastructure team to deploy new TeamCity agent images according to [packer/README.md](./packer/README.md) Closes cockroachdb#74617. Release note (build change): Upgrade to Go 1.17.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following critical go bugs have been fixed upstream and need to be integrated in release builds of CockroachDB:
The text was updated successfully, but these errors were encountered: