Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: TestUnreadFlowControlReturned_Server failures with stream error "NO_ERROR" since 2021-10-05 #49645

Closed
bcmills opened this issue Nov 17, 2021 · 6 comments
Closed

x/net/http2: TestUnreadFlowControlReturned_Server failures with stream error "NO_ERROR" since 2021-10-05 #49645

bcmills opened this issue Nov 17, 2021 · 6 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2021 •
edited
Loading 

--- FAIL: TestUnreadFlowControlReturned_Server (0.12s)
    --- FAIL: TestUnreadFlowControlReturned_Server/read-1-byte-and-close (0.01s)
        server_test.go:3891: read-1-byte-and-close stream error: stream ID 1; NO_ERROR; received from peer
FAIL
FAIL	golang.org/x/net/http2	26.435s

greplogs --dashboard -md -l -e '(?ms)FAIL: TestUnreadFlowControlReturned.*stream error: stream ID \d+; NO_ERROR'

2021-11-16T21:27:03-e8b54de-f659183/dragonfly-amd64
2021-11-16T21:27:03-e8b54de-3729a67/freebsd-386-11_4
2021-11-07T04:57:22-b53810d-9e6ad46/freebsd-386-12_2
2021-11-07T04:56:11-b53810d-85493d5/windows-386-2008
2021-11-05T17:23:06-ce13745-37951d8/dragonfly-amd64
2021-11-03T18:37:22-4a448f8-cfd016d/dragonfly-amd64
2021-10-26T15:20:53-d418f37-1b2362b/dragonfly-amd64
2021-10-18T15:54:41-4f30a5c-c091767/freebsd-386-12_2
2021-10-14T17:25:44-2b766c0-2ac3bdf/freebsd-amd64-11_4
2021-10-11T15:28:50-3b03d30-702e337/linux-386-clang
2021-10-06T20:21:49-62292e8-f580b75/freebsd-386-12_2
2021-10-05T00:13:12-d4b1ae0-e5f6d8d/dragonfly-amd64

CC @neild
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Nov 17, 2021
@bcmills bcmills added this to the Go1.18 milestone Nov 17, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Nov 17, 2021

(The failing test appears to be the regression test for #16481.)

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/364834 mentions this issue: http2: avoid spurious RoundTrip error when server closes and resets stream

@neild
Copy link
Contributor

neild commented Nov 18, 2021

@gopherbot Please open backport issues for 1.16 and 1.17. This creates test flakiness.

This was referenced Nov 18, 2021
Closed
Closed
@gopherbot
Copy link
Contributor

Backport issue(s) opened: #49661 (for 1.16), #49662 (for 1.17).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@bcmills bcmills mentioned this issue Nov 22, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/368379 mentions this issue: [internal-branch.go1.17-vendor] http2: avoid spurious RoundTrip error when server closes and resets stream

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/368378 mentions this issue: [internal-branch.go1.16-vendor] http2: avoid spurious RoundTrip error when server closes and resets stream

gopherbot pushed a commit to golang/net that referenced this issue Dec 1, 2021
@neild @mknyszek
[internal-branch.go1.17-vendor] http2: avoid spurious RoundTrip error…
94fb2bc 
… when server closes and resets stream

Avoid a race condition between RoundTrip and the read loop when the
read loop reads a response followed by an immediate stream reset.

For golang/go#49645
Fixes golang/go#49662

Change-Id: Ifb34e2dcb8cc443d3ff5d562cc032edf09da5307
Reviewed-on: https://go-review.googlesource.com/c/net/+/364834
Trust: Damien Neil <[email protected]>
Run-TryBot: Damien Neil <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
(cherry picked from commit 6a13c67)
Reviewed-on: https://go-review.googlesource.com/c/net/+/368379
Reviewed-by: Michael Knyszek <[email protected]>
gopherbot pushed a commit to golang/net that referenced this issue Dec 1, 2021
@neild @mknyszek
[internal-branch.go1.16-vendor] http2: avoid spurious RoundTrip error…
5533dda 
… when server closes and resets stream

Avoid a race condition between RoundTrip and the read loop when the
read loop reads a response followed by an immediate stream reset.

For golang/go#49645
Fixes golang/go#49661

Change-Id: Ifb34e2dcb8cc443d3ff5d562cc032edf09da5307
Reviewed-on: https://go-review.googlesource.com/c/net/+/364834
Trust: Damien Neil <[email protected]>
Run-TryBot: Damien Neil <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
(cherry picked from commit 6a13c67)
Reviewed-on: https://go-review.googlesource.com/c/net/+/368378
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
This was referenced Mar 30, 2022
Closed
Open
dteh pushed a commit to dteh/fhttp that referenced this issue Jun 22, 2022
@neild
http2: avoid spurious RoundTrip error when server closes and resets s…
ef14212 
…tream

Avoid a race condition between RoundTrip and the read loop when the
read loop reads a response followed by an immediate stream reset.

Fixes golang/go#49645

Change-Id: Ifb34e2dcb8cc443d3ff5d562cc032edf09da5307
Reviewed-on: https://go-review.googlesource.com/c/net/+/364834
Trust: Damien Neil <[email protected]>
Run-TryBot: Damien Neil <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
fedosgad pushed a commit to fedosgad/oohttp that referenced this issue Jun 22, 2022
@neild @mknyszek
[internal-branch.go1.17-vendor] http2: avoid spurious RoundTrip error…
64ac61a 
… when server closes and resets stream

Avoid a race condition between RoundTrip and the read loop when the
read loop reads a response followed by an immediate stream reset.

For golang/go#49645
Fixes golang/go#49662

Change-Id: Ifb34e2dcb8cc443d3ff5d562cc032edf09da5307
Reviewed-on: https://go-review.googlesource.com/c/net/+/364834
Trust: Damien Neil <[email protected]>
Run-TryBot: Damien Neil <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
(cherry picked from commit 6a13c67c3ce400be1b91076053a994c2d1ebf01b)
Reviewed-on: https://go-review.googlesource.com/c/net/+/368379
Reviewed-by: Michael Knyszek <[email protected]>
@golang golang locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@neild @bcmills @gopherbot