net/http: TestNoSniffExpectRequestBody_h2 failures with "NO_ERROR"

[bcmills]

greplogs --dashboard -md -l -e 'FAIL: TestNoSniffExpectRequestBody_h2'

2021-11-22T19:43:16-8f559bc/linux-386-stretch
2021-11-14T17:38:42-5337e53/openbsd-386-68
2021-10-15T20:34:15-1b072b3/freebsd-arm-paulzhol
2021-10-13T04:00:15-e8f99da/dragonfly-amd64
Note: 1-year break here!
2020-10-30T16:27:42-676ad56/solaris-amd64-oraclerel
2020-10-30T00:47:37-e62adb1/aix-ppc64
2020-10-30T00:23:50-faa4426/aix-ppc64
2020-10-30T00:13:25-60f42ea/solaris-amd64-oraclerel

It's not obvious to me, but given the similarity of the failure mode I suspect that perhaps bundling in the fix for #49645 will also fix this..?

CC @neild

[bcmills]

(Marking as release-blocker for 1.18 because the 1-year gap in failures makes me suspect a 1.18 regression.)

[heschi]

Do we think this should block the beta?

[neild]

The more recent failures are different from the ones a year ago. There isn't enough evidence in the test output to be sure, but I think the recent failures are caused by the test taking more than 10 seconds to run; the test makes a request with ExpectContinueTimeout set to 10 seconds and fails if it it runs over that timeout. Probably just a slow builder.

[gopherbot]

Change https://golang.org/cl/368083 mentions this issue: net/http: increase timeout in TestNoSniffExpectRequestBody_h[12]

[bcmills]

Hmm... I'm skeptical that it's a builder slowness issue because the test itself doesn't seem to be taking anywhere near that long. From the first failure in the above logs:

--- FAIL: TestNoSniffExpectRequestBody_h2 (0.01s)
    clientserver_test.go:1341: stream error: stream ID 1; NO_ERROR; received from peer
FAIL
FAIL	net/http	13.007s

That appears to be only 10ms running the test, not 10s.

[neild]

Oh, I had the timeline backwards. The old failures are from the 10s timeout being exceeded, the new failures are something different.

[toothrot]

Friendly check-in here, this is one of the last two issues blocking the beta of 1.18. Has there been an update recently?

[neild]

Looking now, but I believe this is present in 1.17.5 and does not need to block the 1.18 beta. (Should be fixed before rc1, though.)

[toothrot]

Thanks! I removed the label. We'll consider it a release-blocker for RC1.

[cagedmantis]

Checking in on this as a release-blocking issue. Are there any updates?

[neild]

I believe the fix for #49645 fixed this one as well. Unless I'm misreading the builder logs, I see no instances of this failure since that fix landed.

[bcmills]

Unless I'm misreading the builder logs, I see no instances of this failure since that fix landed.

Agreed: this does not appeared to have recurred since the backports for that fix were merged. Thanks!

greplogs --dashboard -md -l -e 'FAIL: TestNoSniffExpectRequestBody_h2' --since=2021-12-02

[no results]