Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user agent check for docker notifications #6689

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Jan 3, 2019

Fixes #5729
Fixes #5222

@coveralls
Copy link

coveralls commented Jan 3, 2019

Pull Request Test Coverage Report for Build 10170

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 65.487%

Files with Coverage Reduction New Missed Lines %
src/jobservice/logger/service.go 2 65.15%
src/core/api/repository.go 3 42.23%
src/jobservice/period/enqueuer.go 4 77.66%
Totals Coverage Status
Change from base Build 10162: -0.01%
Covered Lines: 13605
Relevant Lines: 20775

💛 - Coveralls

@steven-zou
Copy link
Contributor

#6687 has the same problem.

Copy link
Contributor

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good contributions. Switch the event whitelist to blacklist to support more agents.

Approve. Thanks, @jkroepke for the contributions.

@jkroepke
Copy link
Contributor Author

jkroepke commented Jan 4, 2019

Fixes #5222

@ywk253100 ywk253100 merged commit f9c1a52 into goharbor:master Jan 4, 2019
@jkroepke jkroepke deleted the patch-1 branch January 4, 2019 17:21
@jkroepke
Copy link
Contributor Author

jkroepke commented Jan 4, 2019

@ywk253100 @steven-zou

Small chance to get this into 1.7.x ?

@steven-zou
Copy link
Contributor

@jkroepke

The PR has missed the 1.7.1 timeline. Let's see if we have other possible rel slot for this PR. And we also need more supporting cases (reasons) to determine whether it can be put into the 1.7.x rel or not.

@Asgoret
Copy link

Asgoret commented Jan 22, 2019

@jkroepke @steven-zou
I wan't to build OKD with registry based on Harbor, but i can't truly use harbor features because when i push images from podman it doesn't seemed in GUI. In which version does this PR will be released?

@Asgoret
Copy link

Asgoret commented Jan 25, 2019

@steven-zou @ywk253100
So.... is there any chance, that this PR will be included in 1.7.x release?

@Asgoret
Copy link

Asgoret commented Jan 29, 2019

@steven-zou @ywk253100
Any information?

@Asgoret
Copy link

Asgoret commented Jan 29, 2019

@wy65701436
Hi! Maybe you can help me. This PR is included in release 1.7.2?

@ywk253100
Copy link
Contributor

@Asgoret The fix will not included in the 1.7.x releases.

@Asgoret
Copy link

Asgoret commented Jan 29, 2019

@ywk253100 Why? Fix is ready and it's huge bug which stop use another container runtime?

@Asgoret
Copy link

Asgoret commented Jan 30, 2019

Use jfrog artifactory. In private conversation they confirmed that they haven't got this issue.

@jomeier
Copy link

jomeier commented Mar 18, 2019

We need this bugfix very urgently. I cant believe that such a huge bug is in this registry.

Even automatic replication doesn't work which is an absolute showstopper for our application.

Isn't it possible to pull this PR in a 1.7.5 ?

Best regards,

Josef

@jomeier
Copy link

jomeier commented Mar 18, 2019

@ywk253100
I can confirm that this PR definitely solves the problem.

Do you have any idea when v1.8 will be released?

Greetings, Josef

@ywk253100
Copy link
Contributor

@jomeier At end of May if everything goes well.

@reasonerjt
Copy link
Contributor

@jomeier we'll try to cherrypick this commit to 1.7.5, targeting early April.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants