-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove user agent check for docker notifications #6689
Conversation
Fixes goharbor#5729 Signed-off-by: Jan-Otto Kröpke <[email protected]>
Pull Request Test Coverage Report for Build 10170
💛 - Coveralls |
#6687 has the same problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good contributions. Switch the event whitelist to blacklist to support more agents.
Approve. Thanks, @jkroepke for the contributions.
Fixes #5222 |
Small chance to get this into 1.7.x ? |
The PR has missed the 1.7.1 timeline. Let's see if we have other possible rel slot for this PR. And we also need more supporting cases (reasons) to determine whether it can be put into the 1.7.x rel or not. |
@jkroepke @steven-zou |
@steven-zou @ywk253100 |
@steven-zou @ywk253100 |
@wy65701436 |
@Asgoret The fix will not included in the 1.7.x releases. |
@ywk253100 Why? Fix is ready and it's huge bug which stop use another container runtime? |
Use jfrog artifactory. In private conversation they confirmed that they haven't got this issue. |
We need this bugfix very urgently. I cant believe that such a huge bug is in this registry. Even automatic replication doesn't work which is an absolute showstopper for our application. Isn't it possible to pull this PR in a 1.7.5 ? Best regards, Josef |
@ywk253100 Do you have any idea when v1.8 will be released? Greetings, Josef |
@jomeier At end of May if everything goes well. |
@jomeier we'll try to cherrypick this commit to 1.7.5, targeting early April. |
Fixes #5729
Fixes #5222