Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman and harbor ui doesn't play well together #1792

Closed
floriankoch opened this issue Nov 9, 2018 · 14 comments
Closed

podman and harbor ui doesn't play well together #1792

floriankoch opened this issue Nov 9, 2018 · 14 comments
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@floriankoch
Copy link

floriankoch commented Nov 9, 2018

Is this a BUG REPORT or FEATURE REQUEST?:

kind bug

Description

podman pushes are not visible in the harbor Ui
There is an issue about this goharbor/harbor#5729
(afaik it affects all clients without "docker" as user agent)

Steps to reproduce the issue:

  1. Setup harbor

  2. push an image with docker -> visible in the ui

  3. push an image with podman -> not visible in the ui

Describe the results you received:

podman and docker behavior is differnet

Describe the results you expected:

podman and docker behavior is identical

Additional information you deem important (e.g. issue happens only occasionally):

As i understand, docker uses "docker" as User-Agent, podman does not

Output of podman version:

podman version 0.10.1.3

Output of podman info:

host:
  BuildahVersion: 1.5-dev
  Conmon:
    package: podman-0.10.1.3-1.gitdb08685.fc28.x86_64
    path: /usr/libexec/podman/conmon
    version: 'conmon version 1.12.0-dev, commit: 4a03e555ee4105308fa4d814d4ce02a059af0b7f-dirty'
  Distribution:
    distribution: fedora
    version: "28"
  MemFree: 257114112
  MemTotal: 16818675712
  OCIRuntime:
    package: runc-1.0.0-56.dev.git78ef28e.fc28.x86_64
    path: /usr/bin/runc
    version: 'runc version spec: 1.0.1-dev'
  SwapFree: 8465399808
  SwapTotal: 8476684288
  arch: amd64
  cpus: 4
  hostname: xxx
  kernel: 4.18.13-200.fc28.x86_64
  os: linux
  uptime: 575h 23m 25.74s (Approximately 23.96 days)
insecure registries:
  registries:
  - https://harbor.lan
  registries:
  - https://harbor.lan
  - docker.io
  - registry.fedoraproject.org
  - quay.io
  - registry.access.redhat.com
  - registry.centos.org
store:
  ContainerStore:
    number: 37
  GraphDriverName: vfs
  GraphOptions: []
  GraphRoot: /home/xxx/.local/share/containers/storage
  GraphStatus: {}
  ImageStore:
    number: 16
  RunRoot: /run/user/1000/run
@baude
Copy link
Member

baude commented Nov 9, 2018

What is your expectation of this issue you've written?

@floriankoch
Copy link
Author

@baude afaik podman should be docker compatible , so my expectation is that i can use any registry with podman as i can use with docker

@baude
Copy link
Member

baude commented Nov 9, 2018

@mtrmac @rhatdan can either of you comment here?

@mtrmac
Copy link
Collaborator

mtrmac commented Nov 9, 2018

The whole point of User-Agent is to differentiate the different clients (e.g. so that the server can provide client-appropriate content, or possibly client-specific workarounds).

Setting User-Agent to a value exactly the same as a different implementation completely defeats the purpose of it.

(See also: the ridiculous web browser User-Agent values – and the harbor check is even worse in that it requires docker to be a prefix.)

@mtrmac
Copy link
Collaborator

mtrmac commented Nov 9, 2018

I can’t find out why the User-Agent restriction exists, hence
goharbor/harbor#5729 (comment) .

@rhatdan
Copy link
Member

rhatdan commented Dec 22, 2018

@floriankoch @mtrmac Any movement on this issue?

@mtrmac
Copy link
Collaborator

mtrmac commented Jan 2, 2019

@rhatdan No replies at all on goharbor/harbor#5729 asking why this exists (though they did accept a PR to add yet another special case in that code for a different client).


c/image does not send a User-Agent value at all, by default; right now it is only set by the calling application, if it wants to (AFAICS buildah does, but skopeo and podman don’t). So to make progress right now, we could 1) add a default User-Agent to c/image 2) send a PR to Harbor to accept that and the buildah value.

OTOH, when the authors won’t even say why that check exists it’s pretty hard to argue that it would be a correct fix, and I am not too thrilled about adding an User-Agent value default for everyone to placate a single seemingly incorrect upstream.


Is it possible to detect that the server is Harbor from the headers it sends? If so, we could maybe add a server-specific quirk to send User-Agent: docker only in that case (which would also be nice in that its users would not have to upgrade).

Obviously, always sending User-Agent: docker is not desirable.

@mtrmac
Copy link
Collaborator

mtrmac commented Jan 4, 2019

Harbor has just merged a PR that removes the User-Agent check, so the next version should hopefully work.

@rhatdan
Copy link
Member

rhatdan commented Jan 4, 2019

Ok I am going to close then.

@rhatdan rhatdan closed this as completed Jan 4, 2019
@floriankoch
Copy link
Author

@mtrmac @rhatdan Thank you for your efforts :)

@rhatdan
Copy link
Member

rhatdan commented Jan 7, 2019

No Problem @floriankoch Keep using podman/libpod and giving us feedback. We want to make the world work for all container engines.

@Asgoret
Copy link

Asgoret commented Jan 22, 2019

@mtrmac @rhatdan can you give link to your PR in harbor Version v1.7.0-3b3311b4 still doesn't work?)

@mtrmac
Copy link
Collaborator

mtrmac commented Jan 22, 2019

goharbor/harbor#6689 for the record.

@Asgoret
Copy link

Asgoret commented Jan 30, 2019

image

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

No branches or pull requests

5 participants