Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conserve sentinel_master_set value between upgraded versions #18875

Merged
merged 6 commits into from
Jul 27, 2023
Merged

Conserve sentinel_master_set value between upgraded versions #18875

merged 6 commits into from
Jul 27, 2023

Conversation

sixeela
Copy link
Contributor

@sixeela sixeela commented Jun 30, 2023

…ersions

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Conserve sentinel_master_set value between upgraded versions

Issue being fixed

Fixes #18874

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@sixeela sixeela requested a review from a team as a code owner June 30, 2023 12:15
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #18875 (45f0321) into main (3af605e) will decrease coverage by 22.50%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18875       +/-   ##
===========================================
- Coverage   67.41%   44.92%   -22.50%     
===========================================
  Files         992      244      -748     
  Lines      108727    13386    -95341     
  Branches     2747     2747               
===========================================
- Hits        73303     6013    -67290     
+ Misses      31489     7070    -24419     
+ Partials     3935      303     -3632     
Flag Coverage Δ
unittests 44.92% <ø> (-22.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 754 files with indirect coverage changes

@MinerYang MinerYang added the release-note/update Update or Fix label Jul 3, 2023
@MinerYang MinerYang assigned MinerYang and unassigned Vad1mo and chlins Jul 3, 2023
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang assigned chlins and unassigned zyyw Jul 5, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit 84a1317 into goharbor:main Jul 27, 2023
@sixeela sixeela deleted the fix-sentinel-master-set branch August 25, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration on harbor.yml file does not include sentinel_master_set
5 participants