Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration on harbor.yml file does not include sentinel_master_set #18874

Closed
sixeela opened this issue Jun 30, 2023 · 0 comments · Fixed by #18875
Closed

Migration on harbor.yml file does not include sentinel_master_set #18874

sixeela opened this issue Jun 30, 2023 · 0 comments · Fixed by #18875
Assignees
@MinerYang
Labels
kind/impact-migration Issues or PR we should be careful about the design and implementation b/c it impacts the migration,

Comments

@sixeela
Copy link
Contributor

sixeela commented Jun 30, 2023

Hello,

As explained in the title, if sentinel_master_set is set in harbor.yml file passed to the migration container, it appears that its value is not passed to the newly generated file.
I'll open a PR related to this issue.

Thank you,
@sixeela sixeela mentioned this issue Jun 30, 2023
Merged
5 tasks
@stonezdj stonezdj added the kind/impact-migration Issues or PR we should be careful about the design and implementation b/c it impacts the migration, label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MinerYang MinerYang

Labels
kind/impact-migration Issues or PR we should be careful about the design and implementation b/c it impacts the migration,
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Conserve sentinel_master_set value between upgraded versions
3 participants
@stonezdj @sixeela @MinerYang