Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick][2.7] fix: add retry on the caller of v2DeleteManifest instead within v2DeleteManifest #18802

Conversation

dkulchinsky
Copy link
Contributor

Comprehensive Summary of your change

Cherry pick to release 2.7 for #18662

Issue being fixed

Fixes #18381

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@dkulchinsky dkulchinsky requested a review from a team as a code owner June 8, 2023 20:18
@dkulchinsky dkulchinsky force-pushed the gc-v2DeleteManifest-retry-on-caller-2.7 branch from 54fb6e5 to 42d693c Compare June 8, 2023 20:18
@dkulchinsky dkulchinsky changed the base branch from main to release-2.7.0 June 8, 2023 20:19
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #18802 (364bd10) into release-2.7.0 (1661406) will decrease coverage by 3.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.7.0   #18802      +/-   ##
=================================================
- Coverage          69.54%   66.41%   -3.13%     
=================================================
  Files                767     1012     +245     
  Lines              95255   108652   +13397     
  Branches               0     2677    +2677     
=================================================
+ Hits               66244    72161    +5917     
- Misses             25336    32524    +7188     
- Partials            3675     3967     +292     
Flag Coverage Δ
unittests 66.41% <0.00%> (-3.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/jobservice/job/impl/gc/garbage_collection.go 45.77% <0.00%> (-1.05%) ⬇️
src/jobservice/job/impl/gc/util.go 35.00% <0.00%> (+6.42%) ⬆️

... and 250 files with indirect coverage changes

@dkulchinsky
Copy link
Contributor Author

@wy65701436 @Vad1mo @zyyw

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 874399f into goharbor:release-2.7.0 Jun 12, 2023
@Vad1mo Vad1mo added the area/gc label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GC retries forever on permanent errors, most commonly on "manifest unknown" (404)
7 participants