[cherry-pick 2.7] GC: correctly handle manifest unknown (404) condition in v2DeleteManifest retry loop

[dkulchinsky]

Comprehensive Summary of your change

cherry pick of #18386 for release 2.7

/cc @Vad1mo & @zyyw

Issue being fixed

Fixes #18381

Please indicate you've done the following:

• Well Written Title and Summary of the PR
• Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
• Accepted the DCO. Commits without the DCO will delay acceptance.
• Made sure tests are passing and test coverage is added if needed.
• Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

[codecov]

Codecov Report

Merging #18534 (6cb6f22) into release-2.7.0 (de4cab1) will increase coverage by 0.14%.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##           release-2.7.0   #18534      +/-   ##
=================================================
+ Coverage          66.40%   66.55%   +0.14%     
=================================================
  Files               1012     1012              
  Lines             108614   108966     +352     
  Branches            2677     2677              
=================================================
+ Hits               72129    72519     +390     
+ Misses             32522    32484      -38     
  Partials            3963     3963              

Flag	Coverage Δ
unittests	66.55% <0.00%> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/jobservice/job/impl/gc/util.go	26.92% <0.00%> (-1.65%)	⬇️

... and 21 files with indirect coverage changes

[dkulchinsky]

UTTEST is failing, but I fail to see how this could be related to my change?

[Vad1mo]

@dkulchinsky I suggest also opening up a PR for 2.8.

[dkulchinsky]

@dkulchinsky I suggest also opening up a PR for 2.8.

Hey @Vad1mo, cherry picked to release-2.8.0

#18542

[dkulchinsky]

Hey @Vad1mo, I think this is good to go?

[dkulchinsky]

Hey @zyyw 👋🏼 hoping you could approve this cherry-pick based on #18386 for v2.7 🙏🏼

[wy65701436]

we should revise this PR in main branch.

[wy65701436]

closed by closed by #18662 (comment)

[Vad1mo]

I would like to see this feature in 2.7 and 2.8, we have a dozen of harbor instances failing because of this error.
Not many users can upgrade from 2.7 to 2.8 because they need the helm chart support.

[dkulchinsky]

I would like to see this feature in 2.7 and 2.8, we have a dozen of harbor instances failing because of this error. Not many users can upgrade from 2.7 to 2.8 because they need the helm chart support.

Thanks @Vad1mo, agree 100% and was asking for the same here

I'm happy to do the PRs as long as there's intention to accept them.

[wy65701436]

@Vad1mo @dkulchinsky If we want to have this enhancement in versions 2.7 and 2.8, we should backport this change instead of the current pull request.

[dkulchinsky]

@wy65701436 that's great! I'm going to prepare PRs today for 2.7 & 2.8 based on #18662

[dkulchinsky]

Cherry picks based on #18662

release 2.7: #18802
release 2.8: #18803

@Vad1mo @wy65701436 @zyyw please 🙏🏼