Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reject from > to in eth_newFilter and don't throw error when f… #1049

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

classicalliu
Copy link
Contributor

…rom / to > tip number in eth_getFilterChanges

  1. When from > to in eth_newFilter params, throw an error with message invalid from and to block combination: from > to, replace for old message header not found
{
    "jsonrpc": "2.0",
    "id": 2,
    "error": {
        "code": -32000,
        "message": "invalid from and to block combination: from > to"
    }
}
  1. Not throw error when from or to > tip number

…rom / to > tip number in `eth_getFilterChanges`
@jjyr jjyr added this pull request to the merge queue Apr 24, 2023
Merged via the queue into develop with commit 2831863 Apr 24, 2023
@Flouse Flouse deleted the new-filter-reject-from-to branch April 24, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants