[v1.3] eth_newFilter incompatibility with eth #1025

gpBlockchain · 2022-07-21T11:59:59Z

Env

url:https://godwoken-alphanet-v1.ckbapp.dev

incompatibility case

The second call eth_getFilterChanges should not have the data from the last call

       it("invoke eth_getFilterChanges 2 times, second logs length must be 0 ", async () => {
            const filterId = await ethers.provider.send("eth_newFilter", [{}]);

            await sendTxToAddBlockNum(3)
            let logs = await ethers.provider.send("eth_getFilterChanges", [filterId]);
            checkLogsIsSort(logs)
            logs = await ethers.provider.send("eth_getFilterChanges", [filterId]);
            expect(logs.toString()).to.be.equal('')
        })

filter : 'fromBlock': 'pending' ,should return invalid from and to block combination: from > to

guopenglin@192 axon % curl --location --request POST 'localhost:8545/' \
--header 'Content-Type: application/json' \
--data-raw '{
        "jsonrpc":"2.0",
        "method":"eth_newFilter",
        "params":[
                {
                        "fromBlock":"pending"
                }
        ],
        "id":73
}'
{"jsonrpc":"2.0","id":73,"error":{"code":-32000,"message":"invalid from and to block combination: from \u003e to"}}
guopenglin@192 axon % 
guopenglin@192 axon % 
guopenglin@192 axon % 
guopenglin@192 axon % curl --location --request POST 'https://godwoken-alphanet-v1.ckbapp.dev' \
--header 'Content-Type: application/json' \
--data-raw '{
        "jsonrpc":"2.0",
        "method":"eth_newFilter",
        "params":[
                {
                        "fromBlock":"pending"
                }
        ],
        "id":73
}'
{"jsonrpc":"2.0","id":73,"result":"0x046ed6136470c6ee84f9099feab6f25d"}%

filter : fromBlock = eth_blockNumber()+1000 ,should filter log.number >= eth_blockNumber()+1000
filter : toBlock = earliest ,should return error msg

guopenglin@192 axon % curl --location --request POST 'https://godwoken-alphanet-v1.ckbapp.dev' \
--header 'Content-Type: application/json' \
--data-raw '{
        "jsonrpc":"2.0",
        "method":"eth_newFilter",
        "params":[
                {
                        "toBlock":"earliest"
                }
        ],
        "id":73
}'
{"jsonrpc":"2.0","id":73,"result":"0x8030aae6fbb589c1a4cd7475fa5d4a64"}%        guopenglin@192 axon % curl --location --request POST 'http://127.0.0.1:8545' \
--header 'Content-Type: application/json' \
--data-raw '{
        "jsonrpc":"2.0",
        "method":"eth_newFilter",
        "params":[
                {
                        "toBlock":"earliest"
                }
        ],
        "id":73
}'
{"jsonrpc":"2.0","id":73,"error":{"code":-32000,"message":"invalid from and to block combination: from \u003e to"}}

eth_getFilterChanges should not return 'Internal error'

jsonRpcRequest: {
  jsonrpc: '2.0',
  method: 'eth_getFilterChanges',
  params: [ '0x9c6fb86fd2fae1a9f1ea691dcab01980' ],
  id: 100
}
jsonRpcResponse: {
  jsonrpc: '2.0',
  id: 100,
  error: { code: -32603, message: 'Internal error' }
}

test code

         it("[[A, B], [A, B]].yes,should return logs", async () => {
                //check get filed id success
                expect(filterMsgMap["topic.[[A, B],[A, B]].yes"].error).to.be.equal(undefined)
                expect(filterMsgMap["topic.[[A, B],[A, B]].yes"].logs.length).to.be.not.equal(0)
                await checkLogsGteHeight(filterMsgMap["topic.[[A, B],[A, B]].yes"].logs, blockHeight)
                await checkLogsIsSort(filterMsgMap["topic.[[A, B],[A, B]].yes"].logs)
            })

test repo:https://github.com/gpBlockchain/godwoken-tests/blob/issue-test/contracts/test/Issue.js#L7

The text was updated successfully, but these errors were encountered:

keroro520 · 2022-07-25T04:01:24Z

The second call eth_getFilterChanges should not have the data from the last call

Empty logs should be represented as [] but not ''.
The last assertion should be changed to

expect(logs).to.be.equal([]);

And I have created a similar testcase before 😄 https://github.com/nervosnetwork/godwoken-tests/pull/143/files#diff-5a9d016b1531b5de7f83f95c594c036c72e18a10fed58d5897157dce20beebbaR66

keroro520 · 2022-07-25T04:09:04Z

filter : 'fromBlock': 'pending' ,should return invalid from and to block combination: from > to

filter : toBlock = earliest ,should return error msg

Your suggestion is a worthy enhancement. Currently, Godwoken-Web3 returns an empty array [], which is okay for users. Let's mark it as a P-Medium enhancement task.

keroro520 · 2022-07-25T04:11:36Z

filter : fromBlock = eth_blockNumber()+1000 ,should filter log.number >= eth_blockNumber()+1000

eth_getFilterChanges should not return 'Internal error'

I do not quite understand these two cases. Would you like to provide more information？ @gpBlockchain

gpBlockchain · 2022-07-25T05:50:56Z

The second call eth_getFilterChanges should not have the data from the last call

Empty logs should be represented as [] but not ''. The last assertion should be changed to
expect(logs).to.be.equal([]);
And I have created a similar testcase before 😄 https://github.com/nervosnetwork/godwoken-tests/pull/143/files#diff-5a9d016b1531b5de7f83f95c594c036c72e18a10fed58d5897157dce20beebbaR66

[].toString() == ""

i will mod message that not use toString expected

gpBlockchain · 2022-07-25T05:58:22Z

I do not quite understand these two cases. Would you like to provide more information

If the current block height < fromBlock, send eth_getFilterChanges should return empty ,but now will return logs that logs.height < fromBlock

gpBlockchain · 2022-07-25T06:13:38Z

I do not quite understand these two cases. Would you like to provide more information

filter : 'fromBlock': 'pending' ,should return invalid from and to block combination: from > to

If the current block height < fromBlock, send eth_getFilterChanges should return empty ,but now will return logs that logs.height < fromBlock

eth_getFilterChanges should not return 'Internal error'
return 'Internal error' when Filters are complex that contains multiple topic conditions ,reproducible with this use case
https://github.com/gpBlockchain/godwoken-tests/blob/issue-test/contracts/test/Issue.js#L78-L126

solidity code

function testLog4(uint256 logCount) public {
        for(uint256 i=0;i<logCount;i++){
            log4(
                bytes32(0x0000000000000000000000000000000000000000000000000000000000000000),
                bytes32(0x0000000000000000000000000000000000000000000000000000000000000001),
                bytes32(0x0000000000000000000000000000000000000000000000000000000000000002),
                bytes32(0x0000000000000000000000000000000000000000000000000000000000000003),
                bytes32(0x0000000000000000000000000000000000000000000000000000000000000004)
            );
        }
    }

constant

let topic0="0x0000000000000000000000000000000000000000000000000000000000000001";
let topic1="0x0000000000000000000000000000000000000000000000000000000000000002";
let topic2="0x0000000000000000000000000000000000000000000000000000000000000003";
let topic3="0x0000000000000000000000000000000000000000000000000000000000000004";

step

invoke deploy contract that contains testLog4 method
send eth_newFillter that fillter is {"topics": [[topic0, topic2,topic3], [null, topic2],[topic1]] }
invoke testLog4 method 20 times
send eth_getFilterChanges

result

eth_getFilterChanges return 'Internal error' expected return log message

keroro520 · 2022-07-27T09:52:44Z

"topics": [[topic0, topic2,topic3], [null, topic2],[topic1]] is invalid as subtopic cannot be null.

keroro520 · 2022-07-27T10:50:22Z

"topics": [[topic0, topic2,topic3], [null, topic2],[topic1]] is invalid as subtopic cannot be null.

It should throw InvalidFilterTopic when creating a filter, but now InternalError. It is a bug.

classicalliu · 2023-03-20T14:59:52Z

It's passed on testnet & alphanet
It returns {"jsonrpc":"2.0","id":73,"result":"0x1"} on my http://localhost:8545(hardhat node)
This test case will also failed in hardhat, from hardhat's code , when fromBlock > latestBlockNumber， fromBlock will set to latestBlockNumber
It returns {"jsonrpc":"2.0","id":73,"result":"0x2"} on hardhat node
It will be fixed by fix(web3): Topic includes null #1024

sunchengzhu · 2023-04-07T07:53:59Z

I use eth_newFilter in alchemy's goerli network, which supports the use of fromBlock greater than the current block height, and the filter will take effect when the block height reaches fromBlock.
And the same scenario on Godwoken alphanet v1.13.0-rc1 eth_getFilterChange returns {"jsonrpc":"2.0","id":1,"error":{"code":-32000,"message":"header not found"}}.

sunchengzhu · 2023-04-07T15:15:17Z

I found that the first call of eth_getFilterChanges is different in hardhat and geth. Is godwoken consistent with hardhat or geth?

Use "fromBlock": "0x1" to create a filter
Pass in the created filter_id to call eth_getFilterChanges
Hardhat will return all log arrays from 0x1 to the current block matching, while geth will only return[]

classicalliu · 2023-04-21T07:41:37Z

I use eth_newFilter in alchemy's goerli network, which supports the use of fromBlock greater than the current block height, and the filter will take effect when the block height reaches fromBlock.
And the same scenario on Godwoken alphanet v1.13.0-rc1 eth_getFilterChange returns {"jsonrpc":"2.0","id":1,"error":{"code":-32000,"message":"header not found"}}.

fix: Reject from > to in eth_newFilter and don't throw error when f… #1049

Performs like Geth now

classicalliu · 2023-04-21T07:42:52Z

I found that the first call of eth_getFilterChanges is different in hardhat and geth. Is godwoken consistent with hardhat or geth?

Use "fromBlock": "0x1" to create a filter

Pass in the created filter_id to call eth_getFilterChanges

Hardhat will return all log arrays from 0x1 to the current block matching, while geth will only return[]

We can keep the status quo, which performs like Geth now.

gpBlockchain mentioned this issue Jul 22, 2022

test: Issue test godwokenrises/godwoken-tests#160

Open

Flouse assigned keroro520 Jul 23, 2022

Flouse added the bug Something isn't working label Aug 4, 2022

Flouse assigned classicalliu and unassigned keroro520 Jan 10, 2023

Flouse added the P-Medium label Feb 22, 2023

classicalliu mentioned this issue Mar 17, 2023

fix(web3): Topic includes null #1024

Merged

Flouse transferred this issue from godwokenrises/godwoken-web3 Mar 20, 2023

gpBlockchain assigned sunchengzhu Mar 21, 2023

Flouse mentioned this issue Apr 28, 2023

fix: from > to should compare with number type, not string #1063

Merged

sunchengzhu closed this as completed Apr 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v1.3] eth_newFilter incompatibility with eth #1025

[v1.3] eth_newFilter incompatibility with eth #1025

gpBlockchain commented Jul 21, 2022 •

edited by Flouse

Loading

keroro520 commented Jul 25, 2022

keroro520 commented Jul 25, 2022 •

edited

Loading

keroro520 commented Jul 25, 2022

gpBlockchain commented Jul 25, 2022 •

edited

Loading

gpBlockchain commented Jul 25, 2022

gpBlockchain commented Jul 25, 2022 •

edited

Loading

keroro520 commented Jul 27, 2022

keroro520 commented Jul 27, 2022

classicalliu commented Mar 20, 2023 •

edited

Loading

sunchengzhu commented Apr 7, 2023

sunchengzhu commented Apr 7, 2023 •

edited

Loading

classicalliu commented Apr 21, 2023

classicalliu commented Apr 21, 2023

[v1.3] eth_newFilter incompatibility with eth #1025

[v1.3] eth_newFilter incompatibility with eth #1025

Comments

gpBlockchain commented Jul 21, 2022 • edited by Flouse Loading

Env

incompatibility case

keroro520 commented Jul 25, 2022

keroro520 commented Jul 25, 2022 • edited Loading

keroro520 commented Jul 25, 2022

gpBlockchain commented Jul 25, 2022 • edited Loading

gpBlockchain commented Jul 25, 2022

gpBlockchain commented Jul 25, 2022 • edited Loading

solidity code

step

result

keroro520 commented Jul 27, 2022

keroro520 commented Jul 27, 2022

classicalliu commented Mar 20, 2023 • edited Loading

sunchengzhu commented Apr 7, 2023

sunchengzhu commented Apr 7, 2023 • edited Loading

classicalliu commented Apr 21, 2023

classicalliu commented Apr 21, 2023

gpBlockchain commented Jul 21, 2022 •

edited by Flouse

Loading

keroro520 commented Jul 25, 2022 •

edited

Loading

gpBlockchain commented Jul 25, 2022 •

edited

Loading

gpBlockchain commented Jul 25, 2022 •

edited

Loading

classicalliu commented Mar 20, 2023 •

edited

Loading

sunchengzhu commented Apr 7, 2023 •

edited

Loading