Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Use HFlowContainer to display file dialog options #97892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HolonProduction
Copy link
Member

Followup to #80561 which improves the UI a bit:

Before

Screenshot from 2024-09-06 11-42-54

After

Screenshot from 2024-10-06 18-37-09

Since we are not using a grid container anymore I also switched to using the checkbox label instead of an additional one. This improves usability a bit since the text is now also a click target.

@KoBeWi
Copy link
Member

KoBeWi commented Oct 7, 2024

Related to #95304 and #95140
I think the options were vertical to be more consistent with native dialogs. CC @bruvzg

@bruvzg
Copy link
Member

bruvzg commented Oct 7, 2024

It depends on the platform, on Linux (at least GTK) it's also horizontal. So it should be file, as long as both checkbox and dropdown options look OK.

@HolonProduction
Copy link
Member Author

Dropdowns still work and also the label can't be on another line than the dropdown. Only point that might be somewhat controversial is that dropdowns show the label and then the dropdown while checkboxes show the checkbox and then the label.

I looked at Gnome for inspiration regarding this and they do it exactly the same, so it should be fine, especially since there are no dropdowns in the codebase at the moment (plugins might use them though).

@KoBeWi
Copy link
Member

KoBeWi commented Oct 15, 2024

This can resolve #95079 if the same change is done for FileDialog.

EDIT:
Well that issue is about editor-only, just the same bug applies to FileDialog too.

@bruvzg
Copy link
Member

bruvzg commented Oct 15, 2024

Only point that might be somewhat controversial is that dropdowns show the label and then the dropdown while checkboxes show the checkbox and then the label.

Same on Windows. It's not the case only on macOS, but on macOS we can change this as we want:

Screenshot Windows Screenshot macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants