[FileDialog] Rework option controls. #95140
Draft
+103
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the choice of CheckButton over a CheckBox the correct choice for export with debug? Isn’t Toggle switches (CheckButton) usually used for settings that take immediate effect and should not require the user to click Save or Submit to apply the new state? Also an example from Microsoft https://learn.microsoft.com/en-us/windows/apps/design/controls/toggles#choosing-between-toggle-switch-and-check-box |
Yes, I agree a CheckBox makes more sense than a CheckButton here. I can't think of any use cases for a CheckButton in the FileDialog option controls, as none of them are expected to have an immediate effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95079
GridContainterwith nestedBoxContainers.CheckBoxwithCheckButtonto ensure check element is on the same side asOptionButtonin multiple choice options.