Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ukrainian translation for Linux .desktop file #97686

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

Vovkiv
Copy link

@Vovkiv Vovkiv commented Oct 1, 2024

I was looking at changelogs for 4.4-dev2 and noticed #95275 pull. Seems, that .desktop file is not exposed to Weblate, which means you need manually translate this file (that what I did here).

For Comment, I simply copied and slightly adapted translation from here https://docs.godotengine.org/uk/4.x/about/introduction.html so it is consistent with official translation.
Specifically, this paragraph:

Godot Engine - це багатофункціональний кросплатформний рушій для створення 2D та 3D ігор з єдиним інтерфейсом. Він надає повний набір загальних інструментів, щоб користувачі могли зосередитися на створенні ігор без необхідності винаходити велосипед. Ігри можна експортувати одним клацанням миші на низку платформ, включаючи основні настільні платформи (Linux, macOS, Windows), мобільні платформи (Android, iOS), а також веб-платформи та консолі.

And for GenericName I just translated myself, since Ukrainian translation seems to be quite inconsistent even with itself (I might probably look into this, but this is irrelevant to this PR).

@Vovkiv Vovkiv requested a review from a team as a code owner October 1, 2024 11:13
@bruvzg
Copy link
Member

bruvzg commented Oct 1, 2024

Seems, that .desktop file is not exposed to Weblate, which means you need manually translate this file (that what I did here).

This is also true for other platforms:

Not sure what's the best way to handle these, but we probably should at least mention the existence of these files in the Contributing translations or Editor and documentation localization.

@Vovkiv
Copy link
Author

Vovkiv commented Oct 1, 2024

I'm not good with git. May someone else squash it instead of me until I blown up everything into peaces?

@akien-mga
Copy link
Member

Yes I can take care of squashing.

@akien-mga
Copy link
Member

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

See https://patch-diff.githubusercontent.com/raw/godotengine/godot/pull/97686.patch for which email you're using currently. Alternatively I can change it for you to your GitHub profile's anonymous email if you want.

@Vovkiv
Copy link
Author

Vovkiv commented Oct 1, 2024

Yeah, I know about that. I just use this email and alias without linking to my github/gitlab/etc

@akien-mga
Copy link
Member

Alright, it just means this won't "count" as your first merged contribution from the @Vovkiv account, it will always be a first-time contributor until there's a commit merged that's properly linked to the account.
But if you're fine with that, it can be merged as is.

@Vovkiv
Copy link
Author

Vovkiv commented Oct 1, 2024

Yep. Next time I will learn how to squash commits properly 😅 (probably)

@akien-mga akien-mga added this to the 4.4 milestone Oct 1, 2024
@akien-mga akien-mga merged commit d21a8a8 into godotengine:master Oct 1, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants