-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ukrainian translation for Linux .desktop file #97686
Conversation
This is also true for other platforms:
Not sure what's the best way to handle these, but we probably should at least mention the existence of these files in the Contributing translations or Editor and documentation localization. |
I'm not good with git. May someone else squash it instead of me until I blown up everything into peaces? |
Yes I can take care of squashing. |
For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. See https://patch-diff.githubusercontent.com/raw/godotengine/godot/pull/97686.patch for which email you're using currently. Alternatively I can change it for you to your GitHub profile's anonymous email if you want. |
Yeah, I know about that. I just use this email and alias without linking to my github/gitlab/etc |
Alright, it just means this won't "count" as your first merged contribution from the @Vovkiv account, it will always be a first-time contributor until there's a commit merged that's properly linked to the account. |
Yep. Next time I will learn how to squash commits properly 😅 (probably) |
Thanks! And congrats for your first merged Godot contribution 🎉 |
I was looking at changelogs for 4.4-dev2 and noticed #95275 pull. Seems, that .desktop file is not exposed to Weblate, which means you need manually translate this file (that what I did here).
For
Comment
, I simply copied and slightly adapted translation from here https://docs.godotengine.org/uk/4.x/about/introduction.html so it is consistent with official translation.Specifically, this paragraph:
And for
GenericName
I just translated myself, since Ukrainian translation seems to be quite inconsistent even with itself (I might probably look into this, but this is irrelevant to this PR).