Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Russian translation for Linux .desktop file #95275

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Add Russian translation for Linux .desktop file #95275

merged 1 commit into from
Aug 27, 2024

Conversation

OlesyaGerasimenko
Copy link
Contributor

No description provided.

@OlesyaGerasimenko OlesyaGerasimenko requested a review from a team as a code owner August 8, 2024 08:31
@AThousandShips

This comment was marked as outdated.

Sign in to view
@AThousandShips AThousandShips reopened this Aug 8, 2024
@AThousandShips
Copy link
Member

My bad was wrong area

@AThousandShips AThousandShips added this to the 4.x milestone Aug 8, 2024
@AThousandShips AThousandShips requested a review from a team August 8, 2024 08:33
@akien-mga akien-mga changed the title Add Russian translation Add Russian translation for Linux .desktop file Aug 8, 2024
akien-mga
akien-mga approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Google Translate, seems good.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Aug 8, 2024
@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 8, 2024
@JekSun97
Copy link
Contributor

JekSun97 commented Aug 8, 2024

As a native speaker I can say that everything is correct

H3XAGON3ST
H3XAGON3ST approved these changes Aug 8, 2024
View reviewed changes
Copy link

@H3XAGON3ST H3XAGON3ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the translation is correct

dalexeev
dalexeev approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation and spelling are correct.

@AThousandShips
Copy link
Member

Please squash your commits into one, see here

@OlesyaGerasimenko
Copy link
Contributor Author

Please squash your commits into one, see here

Can I somehow do it in the web interface?

@AThousandShips
Copy link
Member

AThousandShips commented Aug 8, 2024 •
edited
Loading

No you have to use the command line or desktop app

@akien-mga
Copy link
Member

I can squash it myself if you're not familiar with that workflow.

@OlesyaGerasimenko
Copy link
Contributor Author

I can squash it myself if you're not familiar with that workflow.

That would be great, thank you!

@akien-mga akien-mga merged commit 1ead46e into godotengine:master Aug 27, 2024
18 checks passed
@akien-mga
Copy link
Member

akien-mga commented Aug 27, 2024 •
edited
Loading

Thanks! And congrats for your first merged Godot contribution 🎉

@ghost ghost mentioned this pull request Oct 1, 2024
Merged
@Spartan322 Spartan322 mentioned this pull request Jan 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@dalexeev dalexeev dalexeev approved these changes

@H3XAGON3ST H3XAGON3ST H3XAGON3ST approved these changes

Assignees
No one assigned
Labels
cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release enhancement topic:i18n usability
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@OlesyaGerasimenko @AThousandShips @JekSun97 @akien-mga @dalexeev @H3XAGON3ST