Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for many context menu options #97306

Closed
wants to merge 1 commit into from

Conversation

ev13bird
Copy link
Contributor

Added many icons for various context menu options:

  • Editor Scene Tab Menu:
    • Show in FileSystem
    • Play This Scene
  • Inspector Dock Menu:
    • Resource Show in FileSystem
  • Script Editor File Menu:
    • Show in FileSystem
  • Script Editor Scripts List Menu:
    • Save
    • Close
    • Copy Script Path
    • Show in FileSystem
    • Move Up
    • Move Down
    • Sort
  • Shader Editor Scripts List Menu:
    • Show in FileSystem

@ev13bird ev13bird requested review from a team as code owners September 22, 2024 00:01
@timothyqiu
Copy link
Member

I wonder if "Move Up" and "Move Down" are used frequently enough to warrant an icon.

@ev13bird
Copy link
Contributor Author

I wonder if "Move Up" and "Move Down" are used frequently enough to warrant an icon.

That's fair! I'm mostly following the existing conventions of the Scene dock's node context menu:
context_menu

I think having icons for all entries in context menus would help a lot with accessibility; I find that the Scene dock's menu does this well.

@KoBeWi
Copy link
Member

KoBeWi commented Sep 23, 2024

Most context menus either have icons for all items (with possible exceptions) or none.

Scene menu has only 2 icons:
image
It should not have icons at all, see #89747 for justification. Although technically it's a context menu, so not sure.

Script menu has only half of the icons:
image
It's probably fine to have them, but you should add icons to more items. Though it's difficult to justify having icons for 2 save buttons and 4 close buttons I guess.

Shader menu has single icon.
image
It's the same case as script menu. They should be consistent.

Script editor top menu should have no icons. Top menus just have no icons.

The only non-questionable change is the one in the inspector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants