Remove stray item icon from tabs menu #89747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why don't we add icons to all? |
|
None of the top menus have icons and scene tabs menu is similar to that (especially with all these Close and Save actions being similar to Scene menu). There is a risk that it will look inconsistent/cluttered. (script tab menu has no icons either) Also it needs icons for these actions. I think we don't have Close icon in any menu. |
|
I agree with this justifucation. |
akien-mga
approved these changes
Apr 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/godotengine/godot/pull/84882/files#r1434449440
"Show in FileSystem" option in scene tabs menu is the only one with an icon, which looks out of place.
Before:
After:
