[Windows] Only use long executable path when necessary, fix broken apksigner detection. #96777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Sep 10, 2024
akien-mga
reviewed
Sep 10, 2024
akien-mga
added
the
cherrypick:4.3
…ksigner detection.
|
Thanks! |
|
Cherry-picked for 4.3.1. (Only the Android fix, the other one is a 4.4-only regression fix.) |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96762
Seems like Windows does not support
\\?\prefixed long paths when running batch files (works fine with executables), so use for OS execute methods only if path is longer than 260 characters.Fixes #95070
apksignercan't run without validJAVA_HOMEset, and it was updated only after it is called.