Fix Connect Signal Dialog control alignment #96164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #96163
First problem
First problem was that CheckButton and CheckBox didn't have same height.
To solve this I changed CheckBox to use same stylebox as CheckButton, as it uses same margins as Button.
Do you think this is the correct way or should CheckButton height be same as the current CheckBox, or add a style override for this dialog to the CheckBox?
Second problem
Problem two was that LineEdit changed height in some situations.
Believe it has to do if it had a Button in same row or not (This was true in other places too, if it has no "partner" height is 29 else 30).
Example:


To fix this I removed -1 from LineEdit and TextEdit top margin.
Could not find any problems in other places after removing the -1 from top margin (maybe something has changed since then?), appreciate if anyone else can take a look too. There was however an extra +1 to the top margin of from_signal (top left LineEdit) in the connect signal dialog that made it 1px to big after removing -1 from the theme. So the +1 was also removed.
Result
Before:

After:

Compact
Before:

After:
