Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize connection dialog #60478

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Apr 23, 2022

Makes it more compact.

Before and after:
image

  • Advanced button is now at the bottom, so that it doesn't cut method name
  • Deferred and Oneshot are now next to each other

@fire-forge
Copy link
Contributor

feels like they should be somewhere else entirely, as they make funny stairs right now

To avoid the funny stairs, the "Advanced" button could be under the "Receiver Method" LineEdit. It would be less compact, but the labels, LineEdits, and buttons would line up perfectly.

@KoBeWi
Copy link
Member Author

KoBeWi commented Apr 23, 2022

Ok pushed this as a second commit, but something is still wrong lol
image

Also it's funny how whole dialog moves 1 pixel when toggling Advanced mode:
godot windows tools 64_imOFlkdBk2

@seppoday
Copy link

seppoday commented Apr 25, 2022

Maybe move toggle to left side. That way it won't move to right side when you toggle it. It will stay in same place. Also it looks similar to Deffered/Oneshot checkboxes. More consistent?

image

@fire-forge
Copy link
Contributor

fire-forge commented May 19, 2022

The left and right side nodes still don't line up. It appears to be caused by the LineEdit nodes being 1px shorter than button nodes. Increasing the LineEdit StyleBox heights by 1px in the editor theme (editor_themes.cpp) should fix it. This would also affect other LineEdits throughout the editor, but hopefully it doesn't cause any problems.

Screenshot_20220519-102245.png

@KoBeWi
Copy link
Member Author

KoBeWi commented May 19, 2022

This is as much as I can align
image
Tree doesn't have any way to increase its size and I can't use custom minimum size, as it fits to window.

@akien-mga akien-mga merged commit aa6d2b5 into godotengine:master Sep 21, 2022
@KoBeWi KoBeWi deleted the compect_dialog branch September 21, 2022 09:10
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants