Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Timer.start() documentation to match the current behavior. #95485

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Clarify Timer.start() documentation to match the current behavior. #95485

merged 1 commit into from
Aug 16, 2024

Conversation

sepTN
Copy link
Contributor

@sepTN sepTN commented Aug 13, 2024

No description provided.

@sepTN sepTN requested a review from a team as a code owner August 13, 2024 13:11
@AThousandShips AThousandShips added enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 13, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Aug 13, 2024
Mickeon
Mickeon reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the code and it's true.

I wish I caught that sooner in hindsight

doc/classes/Timer.xml Outdated Show resolved Hide resolved
@sepTN sepTN force-pushed the clarify-timer-docs branch from 74ef0df to 336b9a2 Compare August 13, 2024 14:06
@Mickeon
Copy link
Contributor

Mickeon commented Aug 13, 2024

Note that this would still close the misunderstanding of #95480

@akien-mga akien-mga merged commit 63397b5 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips mentioned this pull request Sep 28, 2024
Closed
@jss2a98aj jss2a98aj mentioned this pull request Nov 14, 2024
Merged
@Spartan322 Spartan322 mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation enhancement
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@sepTN @Mickeon @akien-mga @AThousandShips