[Editor] Fix AnimationTrackEditor::timeline_changed signal

[AThousandShips]

Signal was declared with two arguments, emitted with both two and three

The signal emitted by AnimationTimelineEdit has two arguments and left as is, as is the signal from AnimationTrackEdit which is connected via a helper method in AnimationTrackEditor, unsure what the intention might have been there but that signal is never emitted by AnimationTrackEdit, but leaving that for a future cleanup and assessment

Confirmed properly that this fixes the issue, should have confirmed more properly in last attempted fix

• Fixes: AnimationPlayer timeline error #95479

[TokageItLab]

I think the two signals should have different names to avoid confusion, and after then fix the incorrect bindings.

[AThousandShips]

The signal for AnimationTimelineEdit and AnimationTrackEdit you mean?

[AThousandShips]

To clarify, there are tree signals:

---

1:

godot/editor/animation_track_editor.cpp

Line 1888 in 28e65b0

ADD_SIGNAL(MethodInfo("timeline_changed", PropertyInfo(Variant::FLOAT, "position"), PropertyInfo(Variant::BOOL, "timeline_only")));

Emitted here:

godot/editor/animation_track_editor.cpp

Line 1843 in 28e65b0

emit_signal(SNAME("timeline_changed"), ofs, mm->is_alt_pressed());

godot/editor/animation_track_editor.cpp

Line 1821 in 28e65b0

emit_signal(SNAME("timeline_changed"), ofs, mb->is_alt_pressed());

And connected to here:

godot/editor/animation_track_editor.cpp

Line 7202 in 28e65b0

timeline->connect("timeline_changed", callable_mp(this, &AnimationTrackEditor::_timeline_changed));

---

2:

godot/editor/animation_track_editor.cpp

Line 3360 in 28e65b0

ADD_SIGNAL(MethodInfo("timeline_changed", PropertyInfo(Variant::FLOAT, "position"), PropertyInfo(Variant::BOOL, "timeline_only")));

Never emitted

And connected to here:

godot/editor/animation_track_editor.cpp

Line 4733 in 28e65b0

track_edit->connect("timeline_changed", callable_mp(this, &AnimationTrackEditor::_timeline_changed));

---

3:

godot/editor/animation_track_editor.cpp

Line 7104 in 28e65b0

ADD_SIGNAL(MethodInfo("timeline_changed", PropertyInfo(Variant::FLOAT, "position"), PropertyInfo(Variant::BOOL, "timeline_only")));

Emitted here:

godot/editor/animation_track_editor.cpp

Line 6132 in 28e65b0

emit_signal(SNAME("timeline_changed"), pos, p_timeline_only);

godot/editor/animation_track_editor.cpp

Line 6105 in 28e65b0

emit_signal(SNAME("timeline_changed"), pos, false);

godot/editor/animation_track_editor.cpp

Line 3791 in 28e65b0

emit_signal(SNAME("timeline_changed"), p_pos, true, true);

godot/editor/animation_track_editor.cpp

Line 3694 in 28e65b0

emit_signal(SNAME("timeline_changed"), p_new_pos, p_timeline_only, false);

And connected to here:

godot/editor/plugins/animation_player_editor_plugin.cpp

Line 2092 in 28e65b0

track_editor->connect(SNAME("timeline_changed"), callable_mp(this, &AnimationPlayerEditor::_animation_key_editor_seek).bind(false));

[akien-mga]

Thanks!

[AThousandShips]

Thank you!