Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak script editor zoom presets to be more useful #94569

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 21, 2024

The presets are now 50%, 75%, 90%, 100%, 110%, 125%, 150%.

This also mentions Ctrl + mouse wheel and zoom keyboard shortcuts in the tooltip. This method of zooming still allows the same zoom range as before (between 25% and 300%).

Preview

image

image

@Calinou Calinou added this to the 4.x milestone Jul 21, 2024
@Calinou Calinou requested a review from a team as a code owner July 21, 2024 03:50
@AdriaandeJongh
Copy link
Contributor

AdriaandeJongh commented Jul 21, 2024

As the tooltip is getting more specific with this change, it is perhaps unclear how the zoom shortcuts (cmd + + and cmd + - on macOS) tie in to this? Does it go through the preset options or is it also a finetune method? Something to also mention there, probably.

@Calinou
Copy link
Member Author

Calinou commented Jul 21, 2024

Does it go through the preset options or is it also a finetune method?

The zoom keyboard shortcuts use the same increment as the finetune method. I've amended the PR accordingly (see OP for updated screenshots).

@Calinou Calinou force-pushed the script-editor-tweak-zoom-presets branch from 096f74f to 8a8177c Compare July 21, 2024 07:23
@Calinou Calinou force-pushed the script-editor-tweak-zoom-presets branch from 8a8177c to 5b11e3b Compare July 22, 2024 15:33
@mrussogit
Copy link

Looking forward to this! Thank you!

@akien-mga
Copy link
Member

Seems fine to me, though I wonder if we shouldn't keep 200%. It does look pretty big but for use on e.g. screen share / meetings, I could see it being useful (where the shared screen is typically not fullscreen for the viewer).

@AThousandShips
Copy link
Member

Also accessibility, I'd say to keep 200%

@mrussogit
Copy link

It would be great to have a way to reset it back to 100% in a single go, like Ctrl+ click window or a shortcut.

@AThousandShips
Copy link
Member

AThousandShips commented Sep 20, 2024

There is, Ctrl+0 by default

@mrussogit
Copy link

There is, Ctrl+0 by default

Thank you! My vote goes to keep the 200% as well!

@Calinou
Copy link
Member Author

Calinou commented Sep 20, 2024

I've readded the 200% preset and tweaked the tooltip to mention the reset zoom shortcut.

Adding one more preset means we have an even number of presets now though, which means the 100% option is no longer at the middle:

image

I could add one more preset below 100% but it feels overkill.

The presets are now 50%, 75%, 90%, 100%, 110%, 125%, 150%.

This also mentions Ctrl + mouse wheel in the tooltip.
@Calinou Calinou force-pushed the script-editor-tweak-zoom-presets branch from 5b11e3b to 84e278c Compare September 20, 2024 13:42
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Sep 20, 2024
@akien-mga akien-mga merged commit 8738aae into godotengine:master Sep 20, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the script-editor-tweak-zoom-presets branch September 20, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zoom presets of 110% and 120 or 125% in the script editor
6 participants