Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoom presets of 110% and 120 or 125% in the script editor #9794

Closed
devmark404 opened this issue May 21, 2024 · 3 comments · Fixed by godotengine/godot#94569
Closed

Add zoom presets of 110% and 120 or 125% in the script editor #9794

devmark404 opened this issue May 21, 2024 · 3 comments · Fixed by godotengine/godot#94569
Milestone

Comments

@devmark404
Copy link

Describe the project you are working on

I make tutorials for godot

Describe the problem or limitation you are having in your project

When I make tutorials it is common to forget the size of the code text which can make it difficult to read if users see them on small screens.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

When many tutorial creators make tutorials, the code is not visible because they forget to change the zoom

Since version 4.3 includes this option, it will be easier for you to configure the size; however, the code zoom has unnecessary sizes like 25% or 200% and 300%

image

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

I suggest adding the zoom of 110% and 120% or 125% so you can better configure the code size in the tutorials

If this enhancement will not be used often, can it be worked around with a few lines of script?

No

Is there a reason why this should be core and not an add-on in the asset library?

It is already included in the editor, it would just be removing unnecessary sizes and adding new ones

@AThousandShips
Copy link
Member

AThousandShips commented May 21, 2024

I suspect the zoom levels are picked to make the font render well, I'm not sure if levels like 1.1 would work correctly

But my suggestion would be to make these an editor setting instead so you could add your own options

@Calinou
Copy link
Member

Calinou commented May 21, 2024

Ctrl + Mouse wheel already allows you to go through finer zoom levels than what's defined in the presets.

That said, I agree the presets defined here aren't very useful, as 25% is way too small and 200% and more are usually too large.

I'd change them to the following:

  • 50%
  • 75%
  • 90%
  • 100%
  • 110%
  • 125%
  • 150%

We can also add a disabled entry at the end that reads "Ctrl + Mouse wheel: Finetune".

@devmark404
Copy link
Author

Ctrl + Mouse wheel already allows you to go through finer zoom levels than what's defined in the presets.

That said, I agree the presets defined here aren't very useful, as 25% is way too small and 200% and more are usually too large.

I'd change them to the following:

  • 50%
  • 75%
  • 90%
  • 100%
  • 110%
  • 125%
  • 150%

We can also add a disabled entry at the end that reads "Ctrl + Mouse wheel: Finetune".

If that is what you propose, remove sizes that are too large or small

Using Ctrl + Mouse wheel
Other sizes can be achieved as you can see in the comment, I had not noticed it, thank you
image

@Calinou Calinou changed the title Add zoom of 110% and 120 or 125% in the code editor in version 4.3 Add zoom presets of 110% and 120 or 125% in the script editor Jul 21, 2024
@akien-mga akien-mga added this to the 4.4 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants